Skip to content

refactor(benchmarks): clarify workload and scene ownership - #36

Merged
thejustinwalsh merged 7 commits into
feat/benchmark-boundary-localityfrom
feat/benchmark-public-api-audit
Aug 4, 2026
Merged

refactor(benchmarks): clarify workload and scene ownership#36
thejustinwalsh merged 7 commits into
feat/benchmark-boundary-localityfrom
feat/benchmark-public-api-audit

Conversation

@thejustinwalsh

@thejustinwalsh thejustinwalsh commented Aug 3, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • colocate each authored workload definition and public Text scene under its own workload directory
  • move renderer-owned persistent scenes and metadata under explicit technique directories
  • move the retained comparison host out of workloads and into the benchmark surface hierarchy
  • reduce app.tsx to route selection; isolate the shared route identity, controller state machine, persistent layout, and scene composition
  • separate conformance scenes and probe-only adapters from executable benchmark targets
  • preserve warm Advanced Shaping font transitions and retained comparison publication
  • correct the shaping performance probe so each case observes twelve new telemetry reports after its transition
  • publish evidence-backed V1 raster recommendations and an external raster/baker authoring guide

Public API audit

All nine authored workloads use published @pmndrs/text, FontLoader, FontRegistry, raster-subpath, and runtime-bake surfaces. Workload code contains no raw Wasm URL, private baker package, internal package import, renderer allocation, or RAF ownership.

The audit found no missing common rendering API. It explicitly rejects public buffer-slack controls, a second Text flush/commit publication path, and shipped retained-update diagnostics: the required raster transaction already owns bounded capacity, Three matrix traversal owns publication, and diagnostics remain benchmark-only at zero runtime cost.

The accepted V1 reference now links a how-to for authoring external raster and baker packages through the public transaction. The renderer capability matrix distinguishes shipped V1 roles from later color, expanded-effect, paging, and mixed-raster work.

Runtime evidence

  • 61 benchmark unit files and 321 tests passed
  • complete live browser lane passed on WebGPU and forced WebGL2
  • all 21 Bitmap/MTSDF/Slug comparison workload cells rendered sequentially
  • Main, Conformance, and Presentation recovered while retaining exclusive renderer ownership
  • Presentation completed its timed sequence with one renderer, returned to Off-axis 3D, and measured Icon Grid at 60.25 FPS
  • corrected isolated Advanced Shaping run held all five cases at 59.84–60.17 FPS; CJK measured 60.02 FPS, 0.77 ms CPU p95, and 3.82 ms GPU p95
  • React Doctor 0.7.2 reported no findings
  • production package-size hashes are unchanged

Repository gates

  • mise exec -- pnpm benchmarks:check
  • mise exec -- pnpm benchmarks:test:live
  • isolated corrected Advanced Shaping GPU performance probe
  • mise exec -- pnpm benchmarks:check:react-doctor
  • mise exec -- pnpm docs:check
  • mise exec -- pnpm format:check

The benchmark OKF digest and canonical package, API-shape, roadmap, renderer-guidance, plugin-authoring, and chronology documents are refreshed in the same branch. Milestone 10 closes only with the latest top check and every lower stack check green.

@thejustinwalsh thejustinwalsh changed the title feat/benchmark public api audit refactor(benchmarks): clarify workload and scene ownership Aug 3, 2026
@thejustinwalsh
thejustinwalsh marked this pull request as ready for review August 3, 2026 15:57
@thejustinwalsh
thejustinwalsh force-pushed the feat/benchmark-public-api-audit branch from 7472911 to 638b675 Compare August 4, 2026 01:44
@thejustinwalsh
thejustinwalsh merged commit 96bafbd into feat/benchmark-bitmap-conformance Aug 4, 2026
1 of 2 checks passed
thejustinwalsh added a commit that referenced this pull request Aug 4, 2026
* refactor(benchmarks): clarify scene ownership

* docs(benchmarks): record scene ownership evidence

* refactor(benchmarks): isolate harness surfaces

* fix(benchmarks): sample settled shaping cadence

* docs(benchmarks): record public API audit

* docs(text): close raster release review

* docs: replace raster migration guide
thejustinwalsh added a commit that referenced this pull request Aug 4, 2026
* refactor(benchmarks): colocate slug role scenes (#30)

* refactor(benchmarks): colocate slug role scenes

* docs(benchmarks): record slug scene locality

* refactor(benchmarks): remove standalone previews (#31)

* refactor(benchmarks): remove standalone previews

* docs(benchmarks): record persistent renderer cleanup

* refactor(benchmarks): remove renderer asset facades (#33)

* refactor(benchmarks): remove renderer asset facades

* docs(benchmarks): record canonical asset ownership

* refactor(benchmarks): move retained workload scene (#34)

* refactor(benchmarks): move retained workload scene

* docs(benchmarks): record workload scene ownership

* refactor(benchmarks): finish benchmark boundary locality (#35)

* refactor(benchmarks): finish boundary locality

* docs(benchmarks): record boundary locality

* refactor(benchmarks): clarify workload and scene ownership (#36)

* refactor(benchmarks): clarify scene ownership

* docs(benchmarks): record scene ownership evidence

* refactor(benchmarks): isolate harness surfaces

* fix(benchmarks): sample settled shaping cadence

* docs(benchmarks): record public API audit

* docs(text): close raster release review

* docs: replace raster migration guide
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant