This repository was archived by the owner on Oct 2, 2018. It is now read-only.
Add support for URLs as package_name in providers/pip current_installed_version comparison - #127
Closed
wico wants to merge 2 commits into
Closed
Add support for URLs as package_name in providers/pip current_installed_version comparison#127wico wants to merge 2 commits into
wico wants to merge 2 commits into
Conversation
out the real package_name from such a URL (means: We remove all unneeded parts). In the next step we can use the extracted package_name as usual. Signed-off-by: Martin Wilhelm <martin@system4.org>
wico
changed the title
Author
|
Travis does is somehow restricted, that affects not only my PR: /home/travis/.rvm/rubies/ruby-2.0.0-p576/lib/ruby/2.0.0/open-uri.rb:223:in `open_loop': redirection forbidden: http://cookbooks.opscode.com/api/v1/cookbooks/minitest-handler/versions/1.1.2/download -> https://s3.amazonaws.com/community-files.opscode.com/cookbook_versions/tarballs/4922/original/minitest-handler.tgz?1383093187 (RuntimeError) |
Member
|
No, I've long held that I don't want to re-implement pip features in this code. Passing URLs isn't doable idempotently and so is not supported. |
Author
|
Some lines later it seems to be supported (see line 136 and ff.). However - I'll continue without this cookbook and build a RPM instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In case we use an URL (as package_name) for pip we have to filter out
the real package_name from such an URL (means: We remove all unneeded
parts).
In the next step we can use the extracted package_name as usual too look up and compare with current installed packages.
Without such a change, the current_installed_version always returns NIL.
Signed-off-by: Martin Wilhelm martin@system4.org