Skip to content
This repository was archived by the owner on Oct 2, 2018. It is now read-only.

Add support for URLs as package_name in providers/pip current_installed_version comparison #127

Closed
wico wants to merge 2 commits into from
Closed

Add support for URLs as package_name in providers/pip current_installed_version comparison #127

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
af50adf
In case we use an URL (as package_name) for pip we have to filter
wico Nov 4, 2014
6abd1d4
Reverted metadata version bump.
wico Nov 4, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions providers/pip.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,12 @@ def load_current_resource
def current_installed_version
@current_installed_version ||= begin
out = nil
# In case we feed pip with an URL, one has to filter out the package_name part
if new_resource.package_name.downcase.start_with?('http:', 'https:') || ['git', 'hg', 'svn'].include?(new_resource.package_name.downcase.split('+')[0])
package_name = new_resource.package_name.match(/^.*\/(\w*)[^\/].*$/)[-1]
else
package_name = new_resource.package_name.gsub('_', '-')
end
pattern = Regexp.new("^#{Regexp.escape(package_name)} \\(([^)]+)\\)$", true)
shell_out("#{which_pip(new_resource)} list").stdout.lines.find do |line|
out = pattern.match(line)
Expand Down