add manifest schema for workflow file#1100
Merged
dOrgJelli merged 13 commits intoorigin-devfrom Aug 27, 2022
Merged
Conversation
fetsorn
requested review from
dOrgJelli,
krisbitney,
namesty and
nerfZael
as code owners
fetsorn
changed the title
cbrzn
reviewed
Aug 9, 2022
Contributor
cbrzn
left a comment
cbrzn
left a comment
There was a problem hiding this comment.
I think it would make sense not to create a new package for the workflow manifest but rather, to add it to the wrap manifests (will live along with Abi). Since IIRC we are making the workflow a part of the WRAP protocol
Niraj-Kamdar
suggested changes
Aug 10, 2022
Contributor
Niraj-Kamdar
left a comment
Niraj-Kamdar
left a comment
There was a problem hiding this comment.
LGTM once the requested changes are addressed
Niraj-Kamdar
previously approved these changes
Aug 15, 2022
Contributor
|
@fetsorn Can you fix the conflicts so we can get this merged and then would be able to merge the |
Niraj-Kamdar
previously approved these changes
Aug 23, 2022
|
This pull request fixes 1 alert when merging 87d8853 into 58757a4 - view on LGTM.com fixed alerts:
|
|
This pull request fixes 1 alert when merging a52470c into 58757a4 - view on LGTM.com fixed alerts:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #970.
The Uri field in the workflow script has type
anyso that it is compatible with core'sTUri extends URI | Stringtype.