refactor workflow from core to cli#1136
Merged
dOrgJelli merged 5 commits into970-workflow-manifestfrom Aug 26, 2022
Merged
Conversation
fetsorn
requested review from
dOrgJelli,
krisbitney,
namesty and
nerfZael
as code owners
Contributor
Niraj-Kamdar
left a comment
Niraj-Kamdar
left a comment
There was a problem hiding this comment.
Awesome work! Thanks for pushing this to completion.
Just a minor chnage: args in wokrflow aren't a required property. for void function it can be undefined.
cbrzn
approved these changes
Aug 18, 2022
Contributor
cbrzn
left a comment
cbrzn
left a comment
There was a problem hiding this comment.
Amazing work :-D I really like this approach of polywrap.test
|
This pull request fixes 1 alert when merging d984e6c into bb61d1c - view on LGTM.com fixed alerts:
|
Niraj-Kamdar
approved these changes
Aug 22, 2022
Contributor
Niraj-Kamdar
left a comment
Niraj-Kamdar
left a comment
There was a problem hiding this comment.
Awesome! Thanks for pushing this to completion
fetsorn
force-pushed
the
fetsorn/1130-workflow-refactor
branch
from
6f575b2 to
d984e6c
Compare
fetsorn
force-pushed
the
fetsorn/1130-workflow-refactor
branch
from
d984e6c to
3c642cf
Compare
|
This pull request fixes 1 alert when merging 3c642cf into 2caaf88 - view on LGTM.com fixed alerts:
|
|
This pull request fixes 1 alert when merging c977020 into e6e0ebb - view on LGTM.com fixed alerts:
|
dOrgJelli
force-pushed
the
fetsorn/1130-workflow-refactor
branch
from
c977020 to
3c642cf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #1100
Resolves #1131