Use opaque pointers in tracing structs to prevent accidental derefs#4667
Merged
SeanTAllen merged 1 commit intoponylang:mainfrom Mar 29, 2025
Merged
Use opaque pointers in tracing structs to prevent accidental derefs#4667SeanTAllen merged 1 commit intoponylang:mainfrom
SeanTAllen merged 1 commit intoponylang:mainfrom
Conversation
ponylang-main
added
the
discuss during sync
Member
|
This is for the flight recorder stuff only yes? |
Contributor
Author
No, this applies to all uses of tracing events.. it would be bad if the normal background tracing thread tries to dereference an actor pointer after the actor has already been destroyed (whether running in flight recorder mode or not).. |
ponylang-main
removed
the
discuss during sync
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.