Add osu!direct previews - #1286
Merged
Merged
Conversation
peppy
reviewed
Sep 25, 2017
| private BeatmapManager beatmaps; | ||
| private NotificationOverlay notifications; | ||
|
|
||
| public abstract Bindable<bool> PreviewPlaying { get; } |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
peppy
reviewed
Sep 25, 2017
| }, | ||
| }); | ||
|
|
||
| PreviewPlaying.ValueChanged += newValue => playButton.FadeTo(newValue || IsHovered ? 1 : 0, 120, Easing.InOutQuint); |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
peppy
reviewed
Sep 25, 2017
| base.Update(); | ||
|
|
||
| if (PreviewPlaying && playButton.Track != null) | ||
| progressBar.Width = (float)(playButton.Track.CurrentTime / playButton.Track.Length); |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Member
|
Please check out the audio loading wrapper in #1253 (which is now merged). You should be able to share a fair bit of implementation with it |
peppy
reviewed
Oct 2, 2017
| { | ||
| if (newValue) | ||
| { | ||
| if(Preview == null) |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
peppy
reviewed
Oct 2, 2017
| } | ||
| } | ||
|
|
||
| public PlayButton(Bindable<bool> playing) |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Member
|
Why didn't you include the actual preview loading logic inside |
jorolf
force-pushed
the
direct-previews
branch
2 times, most recently
from
October 6, 2017 19:13
1cae591 to
7027a51
Compare
jorolf
force-pushed
the
direct-previews
branch
from
October 6, 2017 20:02
7027a51 to
f3ca6cc
Compare
Reduced publicly facing properties where possible. Also fixes a potentially bad state issue when the beatmapset was changed while a load was in progress.
peppy
previously approved these changes
Oct 13, 2017
peppy
force-pushed
the
direct-previews
branch
from
October 13, 2017 05:19
00811c7 to
5b16f5d
Compare
peppy
approved these changes
Oct 13, 2017
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.