OpenAI Dialog: Extend Session Update Service Event to include all fields that make#45
Merged
pragmatrix merged 2 commits intomasterfrom Jun 30, 2025
Merged
Conversation
1c0ba67 to
7d9f5c3
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR extends the session update flow to carry all relevant parameters—including instructions, voice, temperature, tools, and a newly added toolChoice—through the SessionUpdate event.
- Import and wire up
ToolChoicein the types import andParamsstruct - Add
tool_choicehandling inParams, the client’s send path, and theServiceInputEvent::SessionUpdatevariant - Update the client’s event dispatch to include
tool_choicein outgoingSessionUpdateevents
Comments suppressed due to low confidence (3)
services/openai-dialog/src/lib.rs:48
- If your JSON uses camelCase for this field, add
#[serde(rename = "toolChoice")]totool_choicefor consistency with other parameters.
tool_choice: Option<ToolChoice>,
services/openai-dialog/src/lib.rs:283
- Add a unit or integration test to verify that
tool_choicemakes it throughParamsinto the outgoingSessionUpdateevent.
if let Some(tool_choice) = params.tool_choice {
services/openai-dialog/src/lib.rs:48
- [nitpick] Consider documenting the purpose of
tool_choiceinParamsso users know what values are expected and how it's used downstream.
tool_choice: Option<ToolChoice>,
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sense to be changed.