Skip to content

OpenAI Dialog: Extend Session Update Service Event to include all fields that make #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pragmatrix merged 2 commits into from
Jun 30, 2025
Merged

OpenAI Dialog: Extend Session Update Service Event to include all fields that make #45

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8ac453c
openai: Support to update instructions, voice, and temperature
pragmatrix Jun 30, 2025
7d9f5c3
openai: Support toolChoice
pragmatrix Jun 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 36 additions & 7 deletions services/openai-dialog/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,10 @@ use openai_api_rs::realtime::{
api::RealtimeClient,
client_event::{self, ClientEvent},
server_event::{self, ServerEvent},
types::{self, ItemContentType, ItemRole, ItemStatus, ItemType, RealtimeVoice, ResponseStatus},
types::{
self, ItemContentType, ItemRole, ItemStatus, ItemType, RealtimeVoice, ResponseStatus,
ToolChoice,
},
};
use serde::{Deserialize, Serialize};
use tokio::{net::TcpStream, select};
Expand All @@ -42,6 +45,7 @@ pub struct Params {
pub temperature: Option<f32>,
#[serde(default)]
pub tools: Vec<types::ToolDefinition>,
Comment thread
pragmatrix marked this conversation as resolved.
tool_choice: Option<ToolChoice>,
}

impl Params {
Expand All @@ -54,6 +58,7 @@ impl Params {
voice: None,
temperature: None,
tools: vec![],
tool_choice: None,
}
}
}
Expand Down Expand Up @@ -113,9 +118,18 @@ pub enum ServiceInputEvent {
Prompt {
text: String,
},
#[serde(rename_all = "camelCase")]
SessionUpdate {
#[serde(skip_serializing_if = "Option::is_none")]
instructions: Option<String>,
#[serde(skip_serializing_if = "Option::is_none")]
voice: Option<RealtimeVoice>,
#[serde(skip_serializing_if = "Option::is_none")]
temperature: Option<f32>,
#[serde(skip_serializing_if = "Option::is_none")]
tools: Option<Vec<types::ToolDefinition>>,
#[serde(skip_serializing_if = "Option::is_none")]
tool_choice: Option<ToolChoice>,
},
}

Expand Down Expand Up @@ -251,11 +265,6 @@ impl Client {
send_update = true;
};

if !params.tools.is_empty() {
session.tools = Some(params.tools);
send_update = true;
}

if let Some(voice) = params.voice {
session.voice = Some(voice);
send_update = true;
Expand All @@ -266,6 +275,16 @@ impl Client {
send_update = true;
}

if !params.tools.is_empty() {
session.tools = Some(params.tools);
send_update = true;
}

if let Some(tool_choice) = params.tool_choice {
session.tool_choice = Some(tool_choice);
send_update = true;
}

if send_update {
self.send_client_event(ClientEvent::SessionUpdate(client_event::SessionUpdate {
event_id: None,
Expand Down Expand Up @@ -415,10 +434,20 @@ impl Client {
info!("Received prompt");
self.push_prompt(PromptRequest(text)).await?;
}
ServiceInputEvent::SessionUpdate { tools } => {
ServiceInputEvent::SessionUpdate {
instructions,
voice,
temperature,
tools,
tool_choice,
} => {
let event = ClientEvent::SessionUpdate(client_event::SessionUpdate {
session: types::Session {
instructions,
voice,
temperature,
tools,
tool_choice,
..Default::default()
},
..Default::default()
Expand Down
Loading