Skip to content

Rollback uglify3 -> uglify2 - #1077

Merged
marvinhagemeister merged 3 commits into
preactjs:masterfrom
marvinhagemeister:rollback_uglify
Apr 28, 2018
Merged

Rollback uglify3 -> uglify2#1077
marvinhagemeister merged 3 commits into
preactjs:masterfrom
marvinhagemeister:rollback_uglify

Conversation

@marvinhagemeister

Copy link
Copy Markdown
Member

Seems like uglify3's behaviour has changed with regards to mangling properties. This reverts uglify back to v2.

Fixes #1075

@coveralls

coveralls commented Apr 26, 2018

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 100.0% when pulling a0bfaf3 on marvinhagemeister:rollback_uglify into f9eb4ce on developit:master.

@marvinhagemeister

Copy link
Copy Markdown
Member Author

Here is a comparison between 8.2.7 and 8.2.8. Only difference in the build artefact is an unnecessary regex escape that has been removed. Apart from that everything is identical:

screen shot 2018-04-27 at 01 48 14

@ForsakenHarmony

Copy link
Copy Markdown
Member

hmm interesting

@developit developit left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for the test. I had thought for some reason we already had this test!

@marvinhagemeister

Copy link
Copy Markdown
Member Author

@developit We have one that checks if the non-transpiled files have the correct exports, but not one that checks the transpiled output

@marvinhagemeister

Copy link
Copy Markdown
Member Author

I've played around with uglifyjs@3 a bit more, but still haven't had any success. There is a flag to list properties that should not be mangled (--mangle-props reserved=['foo','bar']) but I have trouble getting the options object and checks to reliably work.

I'll merge this, so that we can make a 8.2.9 hotfix release. After that we can look how to upgrade to uglifyjs@3 or if we should switch to GCC.

@marvinhagemeister
marvinhagemeister merged commit 9f38cd0 into preactjs:master Apr 28, 2018
@marvinhagemeister
marvinhagemeister deleted the rollback_uglify branch April 28, 2018 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants