fix: allow render function to return null - #669
Merged
Conversation
In react components are allowed to return null from the render function
Member
|
Any TS folks like @mseddon want to approve? |
Contributor
|
LGTM! |
| @@ -1,5 +1,5 @@ | |||
| declare namespace preact { | |||
| interface ComponentProps<C extends Component<any, any> | FunctionalComponent<any>> { | |||
| interface ComponentProps<C extends Component<PropsType, any> | FunctionalComponent<PropsType>, PropsType> { | |||
Contributor
There was a problem hiding this comment.
What's the reason for adding PropsType here?
Contributor
Author
There was a problem hiding this comment.
Isn't it just more specific/correct than 'any'?
Contributor
There was a problem hiding this comment.
As PropsType isn't used in this interface and isn't constrained in any way, it provides no more safety than simply any, and only adds complexity.
developit
approved these changes
Jul 2, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In react components are allowed to return null from the render function