Skip to content

fix: detect host/build dependency changes in --check/--dry-run - #6457

Merged
Hofer-Julian merged 1 commit into
prefix-dev:mainfrom
baszalmstra:claude/determined-cannon-qkjp60
Jul 17, 2026
Merged

fix: detect host/build dependency changes in --check/--dry-run#6457
Hofer-Julian merged 1 commit into
prefix-dev:mainfrom
baszalmstra:claude/determined-cannon-qkjp60

Conversation

@baszalmstra

@baszalmstra baszalmstra commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Description

--check/--dry-run keyed off LockFileDiff, which only compares resolved packages by location and so misses host/build dependency edits to source packages. Now they key off the lock_updated re-solve signal instead. --check returns an error rather than exit(1). Adds a regression test.

Fixes #6445

How Has This Been Tested?

Added a unit test.

AI Disclosure

  • This PR contains AI-generated content.
    • I have tested any AI-generated content in my PR.
    • I take responsibility for any AI-generated content in my PR.

Tools: Claude Opus 4.8

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added sufficient tests to cover my changes.
  • I have verified that changes that would impact the JSON schema have been made in schema/model.py.

@baszalmstra
baszalmstra requested a review from Hofer-Julian June 26, 2026 12:01
@baszalmstra
baszalmstra force-pushed the claude/determined-cannon-qkjp60 branch from cd8ef9e to 0fd56d2 Compare July 14, 2026 15:36

@Hofer-Julian Hofer-Julian left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, only had small comments

Comment thread crates/pixi_cli/src/lock.rs Outdated
Comment thread crates/pixi_cli/src/lock.rs Outdated
@baszalmstra
baszalmstra force-pushed the claude/determined-cannon-qkjp60 branch from 0fd56d2 to bd8f5b1 Compare July 17, 2026 09:26
@baszalmstra
baszalmstra requested a review from Hofer-Julian July 17, 2026 09:40
@Hofer-Julian
Hofer-Julian merged commit aa252c9 into prefix-dev:main Jul 17, 2026
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

pixi lock --check --dry-run does ignore host and build dependencies

2 participants