fix(client-engine-runtime): handle rejections when timeout expires after backend termination by luis-dfns · Pull Request #29611 · prisma/orm

luis-dfns · 2026-05-29T16:46:37Z

Fix unhandled promise rejection when transaction timeout fires on a dead connection

Problem

When the database terminates a connection's backend (e.g. via idle_in_transaction_session_timeout, pg_terminate_backend, a DB restart, or a network partition) before $transaction({ timeout }) expires, Prisma's transaction-timeout handler tries to send ROLLBACK on the now-dead connection. The handler is an async callback passed to setTimeout, and nothing awaits its returned promise — so the failed ROLLBACK surfaces as an unhandledRejection that crashes the Node process (default --unhandled-rejections=throw), entirely outside the user's try/catch around $transaction(...).

Root cause

In packages/client-engine-runtime/src/transaction-manager/transaction-manager.ts, #startTransactionTimeout schedules an async callback via createTimeoutIfDefined. The promise it returns is discarded, so any rejection from the #closeTransaction → ROLLBACK chain has no awaiter.

Fix

Wrap the timeout callback body in try/catch, logging the failure via the existing debug helper and swallowing it. Once the timeout fires, the transaction is over by definition and the user can no longer act on the error, so surfacing it as an unhandledRejection is strictly worse than swallowing it.

The in-memory cleanup (status = 'timed_out', removal from the active-transaction map) already runs in #closeTransaction's finally before the rejection propagates, so subsequent queries on the same transaction handle still reject cleanly via the expired-transaction path.

Testing

Added a deterministic regression test that mocks the adapter so executeRaw rejects with a connection-closed error during the timeout-driven rollback.
Confirmed the test fails without the fix

Notes

A cleaner long-term option (skipping ROLLBACK when the connection is known-dead via adapter health state) would benefit all driver adapters but requires changes to the SqlDriverAdapter interface

Reproducing the error

https://github.com/luis-dfns/prisma-timeout-crash-test

…e backend was already terminated

CLAassistant · 2026-05-29T16:46:45Z

All committers have signed the CLA.

coderabbitai · 2026-05-29T16:46:56Z

Walkthrough

This PR updates transaction timeout handling to catch and log errors during timed-out transaction closure, preventing rejected timer callback promises from escaping. A regression test simulates a dead connection, verifies rollback execution and resolved timer callback promises, and confirms subsequent commit and rollback operations reject with TransactionExecutionTimeoutError.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Title check	✅ Passed	The title accurately summarizes the timeout rejection fix after backend termination.
Description check	✅ Passed	The description directly explains the bug, fix, and regression test, matching the changeset.

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

✨ Simplify code

Create PR with simplified code

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

coderabbitai

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In
`@packages/client-engine-runtime/src/transaction-manager/transaction-manager.test.ts`:
- Around line 724-727: Replace the current assertions that use
Promise.all(timerCallbackResults) and timerCallbackResults.length with a direct
check that no timer callback produced a rejected outcome: call
Promise.allSettled(timerCallbackResults) and assert that every settled result
has status === 'fulfilled' (e.g., expect(resultArray.every(r => r.status ===
'fulfilled')).toBe(true)). This removes the tautological toBeDefined and the
coupling to the callback returning a Promise while preserving the guarantee that
no unhandled rejections occurred; update the assertions around
timerCallbackResults accordingly.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 09a63719-c14d-4d56-b46e-df54773d33f7

📥 Commits

Reviewing files that changed from the base of the PR and between 42f9102 and dbc83ec.

📒 Files selected for processing (2)

packages/client-engine-runtime/src/transaction-manager/transaction-manager.test.ts
packages/client-engine-runtime/src/transaction-manager/transaction-manager.ts

…jection via allSettled

tensordreams · 2026-07-23T16:58:38Z

Pushed two commits on top of the existing branch: a merge of the latest main (only a dependabot lockfile bump since the previous merge; no conflicts), and a test tweak addressing the CodeRabbit comment — the timer-callback assertion now uses Promise.allSettled and asserts no rejected results instead of the tautological Promise.all(...).resolves.toBeDefined() plus length check. Verified locally: the full @prisma/client-engine-runtime suite passes (209 tests), and the new test fails when the try/catch in #startTransactionTimeout is reverted, so the regression coverage is real. The fix itself still applies cleanly after #28768/#29727: those changed the start/maxWait phase (which uses a synchronous abort callback), while the execution-timeout path this PR guards is unchanged.

…ter backend termination (prisma#29611) Fix unhandled promise rejection when transaction timeout fires on a dead connection ### Problem When the database terminates a connection's backend (e.g. via `idle_in_transaction_session_timeout`, `pg_terminate_backend`, a DB restart, or a network partition) before `$transaction({ timeout })` expires, Prisma's transaction-timeout handler tries to send `ROLLBACK` on the now-dead connection. The handler is an async callback passed to setTimeout, and nothing awaits its returned promise — so the failed ROLLBACK surfaces as an unhandledRejection that crashes the Node process (default --unhandled-rejections=throw), entirely outside the user's try/catch around `$transaction(...)`. ### Root cause In packages/client-engine-runtime/src/transaction-manager/transaction-manager.ts, #startTransactionTimeout schedules an async callback via createTimeoutIfDefined. The promise it returns is discarded, so any rejection from the #closeTransaction → ROLLBACK chain has no awaiter. ### Fix Wrap the timeout callback body in try/catch, logging the failure via the existing debug helper and swallowing it. Once the timeout fires, the transaction is over by definition and the user can no longer act on the error, so surfacing it as an unhandledRejection is strictly worse than swallowing it. The in-memory cleanup (status = 'timed_out', removal from the active-transaction map) already runs in #closeTransaction's finally before the rejection propagates, so subsequent queries on the same transaction handle still reject cleanly via the expired-transaction path. ### Testing - Added a deterministic regression test that mocks the adapter so executeRaw rejects with a connection-closed error during the timeout-driven rollback. - Confirmed the test fails without the fix ### Notes A cleaner long-term option (skipping ROLLBACK when the connection is known-dead via adapter health state) would benefit all driver adapters but requires changes to the SqlDriverAdapter interface ### Reproducing the error https://github.com/luis-dfns/prisma-timeout-crash-test --------- Co-authored-by: Oleksii Orlenko <alex@aqrln.net> Co-authored-by: Alexey Orlenko's AI Agent <robot@aqrln.net>

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@prisma/adapter-pg](https://github.com/prisma/prisma) ([source](https://github.com/prisma/prisma/tree/HEAD/packages/adapter-pg)) | imports | minor | [`7.9.1` -> `7.10.0`](https://renovatebot.com/diffs/npm/@prisma%2fadapter-pg/7.9.1/7.10.0) | | [@prisma/client](https://www.prisma.io) ([source](https://github.com/prisma/prisma/tree/HEAD/packages/client)) | imports | minor | [`7.9.1` -> `7.10.0`](https://renovatebot.com/diffs/npm/@prisma%2fclient/7.9.1/7.10.0) | --- ### Release Notes <details> <summary>prisma/prisma (@prisma/adapter-pg)</summary> ### [`v7.10.0`](https://github.com/prisma/orm/releases/tag/7.10.0) [Compare Source](prisma/orm@7.9.1...7.10.0) ##### Prisma ORM 7.10.0 Prisma ORM 7.10.0 introduces a compatibility package for running Prisma 7 alongside newer Prisma versions, secures Prisma Studio's local server, and includes fixes across Prisma Client and the PostgreSQL, MariaDB, Neon, SQLite, and Prisma Postgres Serverless adapters. ##### Highlights ##### Run Prisma 7 alongside Prisma 8 This release introduces `@prisma/prisma7`, a compatibility package that lets you retain a matching Prisma 7 CLI and configuration while installing Prisma 8 in the same project. Once 7.10.0 is released, a side-by-side installation can use: ```sh npm install --save-dev prisma@8 @prisma/prisma7@7.10.0 npm install @prisma/client@7.10.0 ``` Use `prisma` for the directly installed Prisma 8 CLI and `prisma7` for Prisma 7: ```sh npx prisma --version npx prisma7 --version npx prisma7 generate npx prisma7 migrate dev npx prisma7 db push ``` Prisma 7 now prefers version-specific configuration files, allowing its configuration to coexist with Prisma 8's `prisma.config.*` files: ```ts // prisma7.config.ts import { defineConfig } from '@prisma/prisma7/config' export default defineConfig({ schema: 'prisma/schema.prisma', migrations: { path: 'prisma/migrations', }, }) ``` Without an explicit `--config` option, Prisma 7 searches for: 1. Root-level `prisma7.config.*` files. 2. `.config/prisma7.*` files. 3. Existing `prisma.config.*` files as a backwards-compatible fallback. The supported extensions are `.js`, `.ts`, `.mjs`, `.cjs`, `.mts`, and `.cts`. An explicit config path always takes precedence: ```sh npx prisma7 generate --config ./custom/prisma7.config.ts ``` New projects initialized by the Prisma 7 CLI use `prisma7.config.ts`. Existing projects containing only `prisma.config.*` continue to work without migration or additional warnings. If a `prisma7.config.*` file exists but cannot be loaded, Prisma reports the error rather than silently falling back to another configuration. The `prisma7` identity is carried through CLI help, version output, shell completion, initialization, migration, database, and generation guidance. Stable Prisma concepts such as `schema.prisma`, Prisma Migrate, `@prisma/client`, and `PRISMA_*` environment variables remain unchanged. Together, the separate executable and configuration namespace make it possible to operate Prisma 7 and Prisma 8 side by side without command or config-file collisions. [#29949](prisma/orm#29949), [#29969](prisma/orm#29969), [#29994](prisma/orm#29994), [#30000](prisma/orm#30000), [#30002](prisma/orm#30002), [#30020](prisma/orm#30020) ##### Prisma Studio security hardening Prisma Studio's local HTTP server now: - Binds explicitly to `127.0.0.1` instead of all network interfaces. - Rejects browser requests from origins other than the active `localhost` or `127.0.0.1` Studio URL. - No longer returns wildcard CORS headers. - Applies the same protections across Node.js, Bun, and Deno. This prevents network clients or malicious websites from accessing Studio's database endpoints while Studio is running. [#29890](prisma/orm#29890) ##### Prisma Client - Fixed `P2002` errors from nested writes so `meta.modelName` identifies the model where the unique constraint violation occurred, including models using `@@map` and `@@schema`. [#29628](prisma/orm#29628) - Fixed automatically batched `findUniqueOrThrow()` calls so every missing record rejects with `P2025`; later misses no longer resolve to `undefined`. [#29654](prisma/orm#29654) - Parameter-chunked statements are now executed atomically in a transaction and rolled back if a later chunk fails. [#29771](prisma/orm#29771) - Improved interactive transaction cleanup during `$disconnect()`, including transactions whose driver-level startup is still in progress. [#28768](prisma/orm#28768) - Prevented transaction cleanup failures after a timeout or backend termination from becoming unhandled promise rejections. [#29611](prisma/orm#29611) - Fixed fluent relation queries when relation fields are literally named `select` or `include`. [#29683](prisma/orm#29683) - Fixed handling of `Date` and `Uint8Array` values created in other JavaScript realms, such as iframes, jsdom, and Node.js `vm` contexts. [#29177](prisma/orm#29177) - Invalid `Date` values passed to `$queryRaw` or `$executeRaw` now throw `PrismaClientValidationError` instead of a generic error. [#29718](prisma/orm#29718) - Fixed `moduleFormat` inference for the `prisma-client` generator in TypeScript projects using `module: "node16"` or `"nodenext"`. Generated output now follows the nearest `package.json` `type`, defaulting to CommonJS when absent. [#29712](prisma/orm#29712) - Deserialized `Bytes` values now own standalone `ArrayBuffer`s rather than exposing unrelated contents from Node.js's shared `Buffer` pool. This applies to both regular and raw query results. [#29701](prisma/orm#29701) - Fixed an incorrect logging context in the remote executor, including Accelerate-backed query execution. [#28892](prisma/orm#28892) ##### Client extensions and observability - Result-extension `compute` callbacks now receive the current model name as a typed second argument: ```ts compute(data, modelName) { // ... } ``` The model name is also preserved when multiple extensions compose the same computed field. [#29782](prisma/orm#29782) - Improved OpenTelemetry context for remotely executed queries: - `$on('query')` callbacks run within the matching `db_query` span. - Events from one operation share the same trace. - Error events are recorded as span exceptions. - Log events continue to be emitted when tracing is disabled or their reported span is unavailable. [#28892](prisma/orm#28892) ##### Driver adapters ##### MariaDB - `@prisma/adapter-mariadb` now accepts an existing `mariadb` pool. External pools remain caller-owned unless `disposeExternalPool: true` is supplied. [#27992](prisma/orm#27992) - Fixed pooled connection leaks during commit, rollback, and failed transaction startup. Connections are now returned with `release()` and transaction-specific listeners are removed before reuse. [#29612](prisma/orm#29612) - Added support for bracketed IPv6 addresses in both `mysql://` and `mariadb://` connection strings. [#29026](prisma/orm#29026) - Prevented malformed connection strings from exposing embedded passwords in retained debug output and diagnostic reports. [#27992](prisma/orm#27992) ##### PostgreSQL, Neon, and Prisma Postgres Serverless - PostgreSQL deadlocks using SQLSTATE `40P01` are now reported as `P2034` transaction write conflicts. [#29717](prisma/orm#29717) - PostgreSQL `RESTRICT` violations using SQLSTATE `23001` are now reported as `P2003`, preserving an available field or constraint name. [#29554](prisma/orm#29554) - `@prisma/adapter-pg` now preserves database constraint names when reporting unique constraint violations through `P2002`. [#29587](prisma/orm#29587) - Prisma Postgres Serverless now prefers the named constraint for `P2002`, falling back to parsed field names when no constraint name is available. [#29801](prisma/orm#29801) - Fixed Neon HTTP adapter serialization for typed parameters such as `Bytes` and `DateTime`. [#29747](prisma/orm#29747) ##### SQLite - `@prisma/adapter-better-sqlite3` now converts previously unhandled SQLite result codes into typed database errors instead of exposing raw driver errors. - The complete `SQLITE_BUSY` family is now mapped to socket timeout errors, with numeric extended result codes preserved where available. [#29794](prisma/orm#29794) ##### CLI and Migrate - `prisma generate` can now offer to install Prisma's agent skills. The opt-in prompt: - Is shown at most once per machine. - Is skipped in CI, containers, Git hooks, npm lifecycle scripts, and watch mode. - Is skipped when `--no-hints` is used or Prisma skills are already installed. - Times out after 30 seconds. - Never causes generation to fail if installation is unsuccessful. [#29690](prisma/orm#29690) - A globally installed CLI now warns during `prisma generate` when its version differs from the project's local `prisma` or `@prisma/client`, and recommends running the local CLI. The check is best-effort and does not fail generation. [#29593](prisma/orm#29593) - `prisma version` and `prisma version --json` now include the resolved Prisma CLI package path, making global-versus-local installation issues easier to diagnose. [#29573](prisma/orm#29573) - Empty or generator-only schema files now report `Schema must contain a datasource block` from `db pull`, `db push`, and `migrate dev`, rather than reaching the schema engine and potentially producing inconsistent errors. [#29657](prisma/orm#29657) - CLI commands now tolerate corrupt, unreadable, or unwritable command-state files. Invalid state is reinitialized, writes are atomic, and persistence failures fall back to in-memory state. [#29609](prisma/orm#29609) - Studio now recognizes semicolon-delimited `sqlserver://` connection strings before reporting the existing explicit message that SQL Server is not supported by Studio. [#29623](prisma/orm#29623) - The AI-agent safety checkpoint now also covers interactive `prisma db push` confirmations involving data-loss warnings, rather than only invocations using `--accept-data-loss`. [#29793](prisma/orm#29793) ##### Performance and reliability - Optimized query-plan execution by eagerly evaluating plans with one unconditional database operation and synchronously interpreting the remaining pure plan. Cached plans remain immutable. [#29004](prisma/orm#29004) - Prevented call-stack overflows when rendering very large parameter lists or combining chunked results containing hundreds of thousands of rows. [#29751](prisma/orm#29751) - Reduced ordinary query setup overhead by constructing fluent-relation field maps lazily and in linear time. Non-fluent queries no longer build this map. [#29752](prisma/orm#29752) ##### Dependencies - Updated the transitive `fast-uri` dependency to a patched release addressing production audit advisories affecting versions through `3.1.3`. [#29758](prisma/orm#29758) </details> --- ### Configuration 📅 **Schedule**: (UTC) - Branch creation - At any time (no schedule defined) - Automerge - At any time (no schedule defined) 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate CLI](https://github.com/renovatebot/renovate).  Reviewed-on: https://git.oirnoir.dev/OIRNOIR/YouTube-Helper-Server/pulls/41

fix(client) unhandled promise rejection when timeout expires while th…

dbc83ec

…e backend was already terminated

coderabbitai Bot reviewed May 29, 2026

View reviewed changes

Comment thread packages/client-engine-runtime/src/transaction-manager/transaction-manager.test.ts Outdated

luckyflores mentioned this pull request Jul 13, 2026

Driver adapters: connection returned to pool with an open transaction (ROLLBACK never sent) when maxWait expires during startTransaction — "there is already a transaction in progress" #29719

Closed

tensordreams changed the base branch from main to v7 July 21, 2026 12:05

tensordreams changed the base branch from v7 to main July 21, 2026 15:10

aqrln and others added 3 commits July 22, 2026 16:12

Merge branch 'main' into main

b89a0bf

Merge remote-tracking branch 'origin/main' into luis-dfns/main

1fb8331

test(client-engine-runtime): assert timer callbacks settle without re…

25d8e18

…jection via allSettled

coderabbitai Bot approved these changes Jul 23, 2026

View reviewed changes

Merge remote-tracking branch 'origin/main' into luis-dfns/main

7ea780c

aqrln changed the title ~~fix unhandled promise rejection when timeout expires while the backend was already terminated~~ fix(client-engine-runtime): handle rejections when timeout expires after backend termination Jul 24, 2026

aqrln approved these changes Jul 24, 2026

View reviewed changes

dosubot Bot added the lgtm This PR has been approved by a maintainer label Jul 24, 2026

aqrln merged commit 02ab1cd into prisma:main Jul 24, 2026
252 of 253 checks passed

coderabbitai Bot mentioned this pull request Aug 10, 2026

fix(adapter-better-sqlite3): recover from failed transactions #29955

Open

5 tasks

coderabbitai Bot mentioned this pull request Aug 19, 2026

fix(adapter-libsql): clean up failed commits #30071

Open

Navigation Menu

Uh oh!

fix(client-engine-runtime): handle rejections when timeout expires after backend termination - #29611

fix(client-engine-runtime): handle rejections when timeout expires after backend termination#29611
aqrln merged 5 commits into
prisma:mainfrom
luis-dfns:main

luis-dfns commented May 29, 2026

Uh oh!

CLAassistant commented May 29, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented May 29, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot left a comment

Uh oh!

Uh oh!

tensordreams commented Jul 23, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

luis-dfns commented May 29, 2026

Problem

Root cause

Fix

Testing

Notes

Reproducing the error

Uh oh!

CLAassistant commented May 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai Bot commented May 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

tensordreams commented Jul 23, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

CLAassistant commented May 29, 2026 •

edited

Loading

coderabbitai Bot commented May 29, 2026 •

edited

Loading