ci(polymarket): publish bounded market recorder image - #280
Conversation
|
Warning Review limit reached
Next review available in: 50 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughAdds a multi-stage Docker image for ChangesPolymarket market recorder image
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant GitHubActions
participant DockerBuild
participant ACR
participant RecorderContainer
GitHubActions->>DockerBuild: Build polymarket-market-recorder image
DockerBuild->>ACR: Push image
GitHubActions->>ACR: Pull image
GitHubActions->>ACR: Check org.opencontainers.image.revision
GitHubActions->>RecorderContainer: Run --help
RecorderContainer-->>GitHubActions: Return --dry-run help output
Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7c160f272f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| pkg-config \ | ||
| && rm -rf /var/lib/apt/lists/* | ||
|
|
||
| COPY prediction-markets/ prediction-markets/ |
There was a problem hiding this comment.
With the workflow's rust_hft build context, this copies only prediction-markets, but that workspace includes crates/ploy-research, whose manifest references ../../../data-pipelines/core and ../../../research-core/search-kernel. Cargo loads all workspace-member manifests before selecting -p new-ploy-runner; reproducing the copied layout with cargo metadata --locked --no-deps fails because /work/data-pipelines/core/Cargo.toml is absent. Consequently this target—and the new entry in an all publication—cannot build until those external path dependencies are included in the image context.
Useful? React with 👍 / 👎.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/acr-publish.yml:
- Around line 208-219: Update the Polymarket market recorder verification step
and its image/launcher contract: make bounded-job invocations require and pass
--dry-run, reject executions that omit it, and replace the help-text grep with
an executable smoke test that confirms --dry-run prevents execution. Preserve
the existing image pull and source-revision validation around the Verify
Polymarket market recorder image step.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: a3965cf3-669d-4e09-8ebd-77d57fde5922
📒 Files selected for processing (2)
.github/workflows/acr-publish.ymlrust_hft/deployment/docker/Dockerfile.polymarket-market-recorder
|
Final focused evidence on head
|
1 participant
Closes #279
Change contract
Publish a dedicated exact-source
new-ploy-runner --features fullOCI target for bounded, dry-run-only ACK Polymarket market recording without changing any running collector.Out of scope
Production ECS deployment/cutover, data collection, reference collection, evidence/snapshot/evaluator logic, and Paper/Shadow/Live execution.
Dependency / merge order
None. Merge before the bounded ACK acquisition issue consumes the immutable image digest.
Focused validation
cargo tree --locked -p new-ploy-runner --features full -e featurescontains nolive-execution.cargo check --locked -p new-ploy-runner --features fullcargo run --locked -p new-ploy-runner --features full -- --help 2>&1 | grep -Fq -- --dry-runcargo test --locked -p new-ploy-runner --features fullgit diff --check.Rollout / rollback impact
Adds one opt-in image repository/target. No service adopts it automatically. Rollback removes the target; already published immutable images remain inert.
Matt flow
Focused infrastructure defect issue -> failing capability proof -> minimum Docker/workflow implementation -> targeted validation -> code review. A separate PRD is unnecessary because #279 defines one bounded publication contract.
Summary by CodeRabbit
New Features
--dry-runoption and displays help by default.Tests