feat(polymarket): publish source-bound quote runner - #423
Conversation
📝 WalkthroughWalkthroughAdds source-revision metadata to the Polymarket runner, creates verified release artifacts from published images, uploads them, and adds static and runtime contract tests to CI. ChangesPolymarket release flow
Estimated code review effort: 3 (Moderate) | ~25 minutes Sequence Diagram(s)sequenceDiagram
participant ACRPublishWorkflow
participant DockerImage
participant ReleaseArtifactHelper
participant ArtifactStorage
ACRPublishWorkflow->>DockerImage: Extract new-ploy-runner
ACRPublishWorkflow->>ReleaseArtifactHelper: Create and verify release artifacts
ReleaseArtifactHelper->>ReleaseArtifactHelper: Generate checksums and manifest
ACRPublishWorkflow->>ArtifactStorage: Upload verified artifact directory
Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0b7309b1b4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Change contract: publish an immutable, source-bound bare-metal Polymarket quote-runner artifact from the exact selected source, with exact CLI, image, binary, and manifest verification.\n\nOut of scope: production deployment/cutover; reference collector, uploaders, raw-ops behavior, snapshots, research logic, and #235.\n\nDependency or merge order: #420 merged first as eb095a7; this PR is based on that exact merge SHA.\n\nFocused validation:\n- deployment/aliyun/test-polymarket-market-recorder-release.sh\n- .github/scripts/test-acr-publish-workflow.sh\n- bash -n and shellcheck for the release helper and test\n- actionlint for acr-publish.yml and ci.yml\n- cargo +1.91 fmt --manifest-path rust_hft/prediction-markets/Cargo.toml --check\n- exact-source new-ploy-runner build and exact --version/-V verification\n- feed::recorded::tests::writer_records_explicit_quote_collection_classification\n- real binary release create/verify plus mutated-source rejection\n- two-axis code review: approved with no P0-P3 findings\n\nRollout/rollback impact: after merge, manually publish the polymarket-market-recorder target, independently verify the artifact, upload it to a digest-addressed OSS release path, and atomically replace only /opt/monday/bin/new-ploy-runner while preserving the old digest-addressed binary and evidence for rollback. No other production identity changes in this PR.
Summary by CodeRabbit
New Features
--versionand-Voptions to display the runner’s source revision.Bug Fixes
Tests