Skip to content

ci: avoid unrelated collector binary links in control-plane gate - #347

Merged
proerror77 merged 1 commit into
mainfrom
codex/ci-collector-control-plane-stability
Jul 24, 2026
Merged

ci: avoid unrelated collector binary links in control-plane gate#347
proerror77 merged 1 commit into
mainfrom
codex/ci-collector-control-plane-stability

Conversation

@proerror77

@proerror77 proerror77 commented Jul 24, 2026

Copy link
Copy Markdown
Owner

Change contract: Run the existing systemd resource-envelope library test without linking unrelated collector binaries in the release-control-plane CI gate.

Acceptance evidence: cargo test -p hft-collector --lib systemd_reference_resource_envelope_is_pinned --locked passed locally and executed the required named test; spec and standards reviews approved.

Out of scope: Collector behavior, deployment configuration, ECS cutover, snapshot/research logic.

Dependency or merge order: None. Collector PR #346 remains separate; after this merges, #346 must be revalidated against main.

Focused validation: git diff --check; cargo test -p hft-collector --lib systemd_reference_resource_envelope_is_pinned --locked.

Rollout/rollback impact: CI-only. Merge before collector PR #346. Revert this one-line workflow change to restore the previous target selection.

Summary by CodeRabbit

  • Tests
    • Updated the Rust CI test command to explicitly target the library test suite while preserving existing test selection and locked dependency behavior.

@coderabbitai

coderabbitai Bot commented Jul 24, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: efa3348d-98b1-4973-a62e-8ac58bcde7fb

📥 Commits

Reviewing files that changed from the base of the PR and between 970f456 and a47df98.

📒 Files selected for processing (1)
  • .github/workflows/ci.yml

📝 Walkthrough

Walkthrough

The Rust CI workflow now runs the hft-collector pinned resource envelope test explicitly against the library target while retaining the existing test selector and locked dependency behavior.

Changes

Collector CI validation

Layer / File(s) Summary
Select the collector library test target
.github/workflows/ci.yml
The hft-collector cargo test command adds --lib while retaining --locked and the existing test selector.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

  • proerror77/monday#56: Adjusts Rust CI scope selection around the collector control-plane validation steps.
  • proerror77/monday#78: Also changes the collector control-plane cargo test invocation in .github/workflows/ci.yml.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title is concise and accurately summarizes the CI change to avoid unrelated collector binary links.
Description check ✅ Passed The description covers the required contract, out-of-scope work, dependency order, validation, and rollback details.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/ci-collector-control-plane-stability

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@proerror77
proerror77 force-pushed the codex/ci-collector-control-plane-stability branch from c69b66f to a47df98 Compare July 24, 2026 12:17
@proerror77
proerror77 merged commit 1cbacae into main Jul 24, 2026
38 checks passed
@proerror77
proerror77 deleted the codex/ci-collector-control-plane-stability branch July 24, 2026 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant