ci: avoid unrelated collector binary links in control-plane gate - #347
Merged
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe Rust CI workflow now runs the ChangesCollector CI validation
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
proerror77
force-pushed
the
codex/ci-collector-control-plane-stability
branch
from
July 24, 2026 12:17
c69b66f to
a47df98
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change contract: Run the existing systemd resource-envelope library test without linking unrelated collector binaries in the release-control-plane CI gate.
Acceptance evidence:
cargo test -p hft-collector --lib systemd_reference_resource_envelope_is_pinned --lockedpassed locally and executed the required named test; spec and standards reviews approved.Out of scope: Collector behavior, deployment configuration, ECS cutover, snapshot/research logic.
Dependency or merge order: None. Collector PR #346 remains separate; after this merges, #346 must be revalidated against main.
Focused validation:
git diff --check;cargo test -p hft-collector --lib systemd_reference_resource_envelope_is_pinned --locked.Rollout/rollback impact: CI-only. Merge before collector PR #346. Revert this one-line workflow change to restore the previous target selection.
Summary by CodeRabbit