Skip to content

test(ploy): update tape config pins for Binance kinds and tick-level sampling - #560

Closed
proerror77 wants to merge 1 commit into
mainfrom
codex/test-kinds-pin-fix
Closed

test(ploy): update tape config pins for Binance kinds and tick-level sampling#560
proerror77 wants to merge 1 commit into
mainfrom
codex/test-kinds-pin-fix

Conversation

@proerror77

Copy link
Copy Markdown
Owner

Change contract

Update workspace_runtime_retirement config pins to the post-#550/#548 tape reality: include_kinds with Binance reference kinds and record_market_updates_quote_sample_ms = 0. Test-only.

Root cause (worth noting)

The scope job's path-gating let #550 and #548 merge with Rust integration regressions skipped, so the stale pins reached main undetected until #559's full run. This is a scope-gating hole: changes to deployment/aliyun/polymarket-market-tape.toml should probably pull in the ploy integration lane (follow-up candidate, not this PR).

Out of scope

  • Scope-gating rule changes

Dependency / merge order

Merge before #559 and the remaining PRs — they all fail this test otherwise.

Focused validation

  • cargo test -p ploy --test workspace_runtime_retirement: 18 passed, 0 failed

Rollout / rollback impact

None — test pin update only.

Issue relationship

Refs #540

…sampling

The scope-gated CI let #550/#548 merge without running
workspace_runtime_retirement; its pinned include_kinds and
quote_sample_ms went stale.

Refs #540
Refs #539
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@coderabbitai

coderabbitai Bot commented Aug 1, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@proerror77, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 13 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 37d71f08-2d47-4c3d-82eb-980b43fb41b2

📥 Commits

Reviewing files that changed from the base of the PR and between c6e0563 and 7ee122d.

📒 Files selected for processing (1)
  • rust_hft/prediction-markets/tests/workspace_runtime_retirement.rs

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@proerror77

Copy link
Copy Markdown
Owner Author

Superseded by #562 (cherry-picked into that branch to break the circular CI dependency).

@proerror77 proerror77 closed this Aug 1, 2026
auto-merge was automatically disabled August 1, 2026 03:06

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant