Skip to content

ci: route Aliyun pins through integration scope - #613

Merged
proerror77 merged 3 commits into
mainfrom
codex/ci-scope-cross-lane-563
Aug 2, 2026
Merged

ci: route Aliyun pins through integration scope#613
proerror77 merged 3 commits into
mainfrom
codex/ci-scope-cross-lane-563

Conversation

@proerror77

@proerror77 proerror77 commented Aug 2, 2026

Copy link
Copy Markdown
Owner

Change contract

Route every non-special deployment/aliyun/** change through the Prediction Markets integration regressions so deployment values pinned by Rust tests cannot merge or land on main with that lane skipped.

Issue relationship

Closes #563

Out of scope

Dependencies and merge order

PR #617 merged first as 59ca4878; this PR is rebased on that commit. No remaining dependency.

Focused validation

  • TDD counterexample: the pinned-Aliyun case initially expected ploy/integration-regressions,ci/rust but received only ci/rust.
  • bash .github/scripts/test-select-rust-ci-scope.sh — passed.
  • pinned-aliyun.txt inventories all six deployment/aliyun path literals read by Rust tests in workspace_runtime_retirement.rs and polymarket_raw.rs; the mechanically extracted and fixture sets have an empty diff.
  • Future .env and .md fixtures both select ploy/integration-regressions,ci/rust, preventing filename and Markdown-exclusion escapes.
  • The rebased workflow retains ci: keep Prediction Markets main runs alive #617's unique main concurrency group and non-main cancellation assertions.
  • git diff --check, bash -n, ShellCheck error-level scan, and Ruby YAML parse — passed.

Rollout and rollback

CI-only fail-closed routing. Aliyun deployment changes may now pay the Prediction Markets integration-lane cost. Rollback is revert, which would reopen the documented false-green path.

Scope exception

None.

@coderabbitai

coderabbitai Bot commented Aug 2, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

The CI workflow now covers all deployment/aliyun/** changes. The Rust CI scope selector adds ploy/integration-regressions for these changes. Fixtures and contract tests cover pinned Aliyun paths, pull requests, pushes, and workflow path coverage.

Changes

Aliyun CI scope coverage

Layer / File(s) Summary
Scope routing and workflow validation
.github/workflows/ploy-ci.yml, .github/scripts/select-rust-ci-scope.sh, .github/scripts/test-select-rust-ci-scope.sh, .github/scripts/fixtures/rust-ci-scope/*
The workflow matches all Aliyun deployment paths. The scope selector includes ploy/integration-regressions. Fixtures and tests validate pinned Aliyun changes and the workflow path contract.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

  • proerror77/monday#56: Introduced the Rust CI scope selector and its tests extended by this change.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Linked Issues check ✅ Passed The changes satisfy issue #563 by adding Aliyun pin inventory, integration-lane routing, and regression-prevention tests.
Out of Scope Changes check ✅ Passed All changes support the linked issue and remain limited to CI routing, fixtures, workflow coverage, and tests.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check ✅ Passed The title clearly states that CI routes Aliyun pins through the integration scope, matching the primary changes.
Description check ✅ Passed The description covers every required template section with clear scope, validation, dependencies, and rollback details.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/ci-scope-cross-lane-563

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@proerror77
proerror77 enabled auto-merge (squash) August 2, 2026 14:40
@proerror77
proerror77 force-pushed the codex/ci-scope-cross-lane-563 branch from e0a02cc to 7f48c68 Compare August 2, 2026 14:46

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e0a02cceb0

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .github/scripts/select-rust-ci-scope.sh
Comment thread .github/workflows/ploy-ci.yml
@proerror77
proerror77 force-pushed the codex/ci-scope-cross-lane-563 branch from 7f48c68 to 1999d1e Compare August 2, 2026 15:43
@proerror77
proerror77 enabled auto-merge (squash) August 2, 2026 15:48
@proerror77
proerror77 merged commit 8db9a34 into main Aug 2, 2026
53 checks passed
@proerror77
proerror77 deleted the codex/ci-scope-cross-lane-563 branch August 2, 2026 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ci: scope path-gating lets cross-lane value pins break main (deployment files pinned by test suites)

1 participant