Skip to content

Make governed GP policies deterministic across resume - #647

Merged
proerror77 merged 1 commit into
mainfrom
codex/agent-cex-gp-determinism-599
Aug 3, 2026
Merged

Make governed GP policies deterministic across resume#647
proerror77 merged 1 commit into
mainfrom
codex/agent-cex-gp-determinism-599

Conversation

@proerror77

@proerror77 proerror77 commented Aug 3, 2026

Copy link
Copy Markdown
Owner

Change contract

Make governed GP execution fail closed on unbounded or time-based policy drift and reproduce the same candidate sequence across interrupted and uninterrupted runs by deriving each iteration RNG from the frozen seed and iteration.

Issue relationship

Refs #599

Out of scope

Factor Bank evidence binding and publication; mission-execute wiring; MCTS subset search; continuous tuning; sealed-holdout opening; Paper, Shadow, LiveSmall, deployment, runtime activation, or new services.

Dependencies and merge order

Core PR #645 is merged. This PR is now based directly on main; merge it before Evidence PR #648 and Mission PR #646.

Focused validation

  • governed_gp_policy_rejects_unadmitted_fields_and_operators — passed.
  • governed_gp_resume_matches_the_uninterrupted_sequence — passed.
  • cargo +1.91 test -p alpha-domain -p alpha-engine --locked — 46 domain and 81 engine tests passed; one credential-dependent LLM test ignored as designed.
  • Scoped Clippy with -D warnings, exact-file Rustfmt, git diff --check, and agent-worktree preflight — passed.
  • Standards review found no hard violations or material smells; Issue Run controlled GP screening into an immutable CEX Factor Bank #599 Spec review found no missing or wrong behavior in this bounded layer.

Rollout and rollback

Research-domain and GP-engine behavior only; no runtime mutation. Roll back by reverting this PR before its dependent Factor Bank PRs.

Scope exception

None.

@coderabbitai

coderabbitai Bot commented Aug 3, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@proerror77, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 42 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 4bf3527d-fe69-41ca-83c1-59c711a6fc2f

📥 Commits

Reviewing files that changed from the base of the PR and between 4aa43ef and 17806c5.

📒 Files selected for processing (2)
  • rust_hft/alpha-harness/domain/src/lib.rs
  • rust_hft/alpha-harness/engine/src/engines/gp.rs

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@proerror77
proerror77 force-pushed the codex/agent-cex-gp-factor-bank-core-599 branch from be73d64 to f1c5d6c Compare August 3, 2026 06:56
@proerror77
proerror77 force-pushed the codex/agent-cex-gp-determinism-599 branch from 86c2419 to 0edce0f Compare August 3, 2026 07:03
Base automatically changed from codex/agent-cex-gp-factor-bank-core-599 to main August 3, 2026 07:07
@proerror77
proerror77 force-pushed the codex/agent-cex-gp-determinism-599 branch from 0edce0f to 17806c5 Compare August 3, 2026 07:14
@proerror77
proerror77 merged commit 2515e0b into main Aug 3, 2026
46 of 47 checks passed
@proerror77
proerror77 deleted the codex/agent-cex-gp-determinism-599 branch August 3, 2026 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant