Bind immutable Factor Bank screening evidence

[proerror77]

Change contract

Bind each immutable CEX Factor Bank revision to the complete governed GP policy, typed research-dataset and walk-forward-partition identities, candidate/evaluator evidence, structured rejection codes, evidence-derived orientation, and the GP-sized multiple-testing family. Emit the strengthened contract as cex-factor-bank-v2 while preserving legacy v1 read/validation compatibility.

Issue relationship

Refs #599

Out of scope

Mission-execute producer wiring; MCTS subset search; continuous tuning; sealed-holdout opening; Paper, Shadow, LiveSmall, deployment, runtime activation, or new databases and services.

Dependencies and merge order

Core PR #645 and Determinism PR #647 are merged. This PR is based directly on main; merge it before the canonical-hash isolation PR and Mission PR #646.

Focused validation

• factor_bank_entry_bindings_fail_closed_when_rehashed — passed.
• factor_bank_rejects_multiple_testing_trials_below_gp_budget and legacy_factor_bank_v1_json_remains_readable — passed.
• Duplicate accepted AST/factor, unknown or holdout evaluator, contradictory verdict/details/codes/orientation, and coverage-drift checks — passed in the owning crate suite.
• cargo +1.91 test -p alpha-domain -p alpha-engine --locked — 48 domain and 81 engine tests passed; one credential-dependent LLM test ignored as designed.
• Scoped Clippy with -D warnings, exact-file Rustfmt, git diff --check, and agent-worktree preflight — passed.
• Standards review found no hard violations. Issue Run controlled GP screening into an immutable CEX Factor Bank #599 Spec review found the domain contract correct and explicitly identified producer wiring as the remaining partial requirement owned by Mission PR Persist governed GP screening into an immutable CEX Factor Bank #646.

Rollout and rollback

Research-domain contracts only; no runtime mutation. Roll back by reverting this PR before the mission-publication PR.

Scope exception

None.

[coderabbitai]

Warning

Review limit reached

@proerror77, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 21 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 70364166-0919-4808-9756-e0ccb11a1414

📥 Commits

Reviewing files that changed from the base of the PR and between 2515e0b and 3f0d08e.

📒 Files selected for processing (1)

• rust_hft/alpha-harness/domain/src/lib.rs

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 56dafbef31

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".