Skip to content

Hash canonical research JSON without buffering - #649

Merged
proerror77 merged 1 commit into
mainfrom
codex/canonical-json-streaming-hash-599
Aug 3, 2026
Merged

Hash canonical research JSON without buffering#649
proerror77 merged 1 commit into
mainfrom
codex/canonical-json-streaming-hash-599

Conversation

@proerror77

Copy link
Copy Markdown
Owner

Change contract

Stream the existing canonical_json_hash JSON bytes directly into SHA-256 while preserving the exact prior wire digest, so Factor Bank and other content-addressed research artifacts do not require a second full payload buffer.

Issue relationship

Refs #599

Out of scope

Mission-execute producer wiring; Factor Bank schema changes; MCTS; sealed-holdout opening; Paper, Shadow, LiveSmall, deployment, runtime activation, new databases or services, prediction-market evaluation, RL, or multi-agent runtime behavior.

Dependencies and merge order

Factor Bank Evidence PR #648 is merged as 3de8b091cf067ab3a23a9f7cb593ac584d85b3ab. Merge this PR before rebuilding Mission PR #646 on main.

Focused validation

  • canonical_json_hash_preserves_the_json_wire_identity pins an independently verified literal SHA-256 and passed.
  • cargo +1.91 test -p alpha-domain --locked — 49 tests passed.
  • cargo +1.91 clippy -p alpha-domain --all-targets --locked -- -D warnings — passed.
  • Package Rustfmt, git diff --check, and agent-worktree preflight — passed.
  • Standards and Issue Run controlled GP screening into an immutable CEX Factor Bank #599 Spec reviews found no blocking findings or scope creep.

Rollout and rollback

Research-domain helper only; canonical identities are unchanged and no runtime state is touched. Roll back by reverting this PR before Mission PR #646 is merged.

Scope exception

None.

@coderabbitai

coderabbitai Bot commented Aug 3, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@proerror77, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 4 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: ca498b8d-64e3-461d-9fdd-2102a703288e

📥 Commits

Reviewing files that changed from the base of the PR and between 3de8b09 and 4b6a88a.

📒 Files selected for processing (1)
  • rust_hft/alpha-harness/domain/src/lib.rs

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@proerror77
proerror77 merged commit 9958928 into main Aug 3, 2026
45 checks passed
@proerror77
proerror77 deleted the codex/canonical-json-streaming-hash-599 branch August 3, 2026 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant