fix(collector): bound Polymarket market-tape upload work - #698
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthroughThe upload service and cutover script now use single-threaded compression and serialized uploads. A Bash contract test validates both commands, and the Rust CI control-plane verification step runs that test. ChangesMarket-tape upload control
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related issues
Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Operator authorization recorded 2026-08-05 CST: merge exception approved only for the known |
Change contract
Bound only the Polymarket market-tape uploader's CPU burst: run zstd with one worker and upload one closed source at a time. Keep the existing rotation, OSS data/manifest/_SUCCESS protocol, and data-quality behavior unchanged.
Issue relationship
None
Out of scope
PM reference uploader and shared environment, collector/timer rotation, CPUQuota, NoSuchKey publication semantics, WebSocket/time-rollover data-quality work, CEX, and any execution runtime.
Dependencies and merge order
None
Focused validation
deployment/aliyun/test-polymarket-market-tape-upload-contract.shpins the unit and canonical cutover argv.bash -nand ShellCheck on both changed shell scripts.deployment/aliyun/test-polymarket-raw-ops-control-plane.shpassed with GNU coreutils date compatibility; CI is the clean Linux authority..github/scripts/test-select-rust-ci-scope.sh, YAML parsing, andgit diff --checkpassed.Rollout and rollback
Controller:
/root; target:i-6we6afeqsvv8uo1ixmyo,polymarket-market-tape-upload.service. After the merged SHA has green CI and its immutable collector release artifact is available, use Aliyun Cloud Assistant to replace only the verifiedExecStartline, preserving the host's current CPUQuota, Nice, pinned environment file, and all other unit bytes. Do not restart an active upload; let the five-minute timer adopt it naturally.Stop and restore the prior unit (current SHA-256
8174c2666d3f1c969e9fd381b7718205045cdfcbde62f25a3c4ac7a9284e0e16) if the baseline identity changes before mutation, systemd's effective argv differs after reload, the uploader fails, or a completed upload lacks any data/manifest/_SUCCESS member. Rollback restores that exact prior file and reloads systemd without interrupting an active upload.Scope exception
None
Summary by CodeRabbit
Bug Fixes
Tests