chore(config): preserve local rules and deployment config edits on origin/main - #727
Conversation
…igin/main Preserve unique local edits from stale main, rebased onto origin/main (4e1165c). All are deletion/simplification or runtime config deltas that origin/main does not have: - .claude/rules/*.md: simplify datetime/standard-patterns/ast-grep rule docs - CLAUDE.md: trim Architecture/Focused Validation sections - deploy/docker-compose.yml: fix build context paths, require CLICKHOUSE_PASSWORD - deployment/aliyun/polymarket-market-tape-upload.*: raise upload timeouts, CPUQuota 200% + Nice=10, quote-sample-ms 1000 Verified: git diff --check clean; all 7 files identical to local HEAD versions (no upstream conflict).
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Warning Review limit reached
Next review available in: 46 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe change removes detailed repository guidance and updates deployment configuration. Compose now requires a ClickHouse password and uses revised build paths. The tape-upload service receives longer timeouts, one-second quote sampling, and updated CPU and process-priority settings. ChangesRepository guidance cleanup
Deployment configuration updates
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@deployment/aliyun/polymarket-market-tape-upload.service`:
- Line 14: The tape-upload contract test must match the service’s updated
arguments. In deployment/aliyun/test-polymarket-market-tape-upload-contract.sh,
update the expected quote sampling value to 1000, revise the stale cutover
expectation, and explicitly verify whether --upload-concurrency 1 should be
retained or removed to match the intended ExecStart contract.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 9ff0b37b-a6d0-47bc-a9d3-d46fb7a93b6b
📒 Files selected for processing (7)
.claude/rules/datetime.md.claude/rules/standard-patterns.md.claude/rules/use-ast-grep.mdCLAUDE.mddeploy/docker-compose.ymldeployment/aliyun/polymarket-market-tape-upload.envdeployment/aliyun/polymarket-market-tape-upload.service
💤 Files with no reviewable changes (2)
- CLAUDE.md
- .claude/rules/standard-patterns.md
…ontract PR #727's ExecStart edit (quote-sample-ms 1000, drop ZSTD_THREADS/upload-concurrency) violated test-polymarket-market-tape-upload-contract.sh, which pins the exact main ExecStart. Revert ExecStart to main; keep the CPUQuota 200% + Nice=10 performance adjustment (not contract-checked).
Change contract
One behavior: preserve unique local edits from the (now-aligned) stale local
mainthatorigin/maindid not contain, rebased ontoorigin/main(4e1165c3).All 7 files are small deletion/simplification or runtime-config deltas.
.claude/rules/datetime.md,standard-patterns.md,use-ast-grep.md:simplify internal rule docs
CLAUDE.md: trim Architecture / Focused Validation sectionsdeploy/docker-compose.yml: fix build context paths (../rust_hft→..),require
CLICKHOUSE_PASSWORDdeployment/aliyun/polymarket-market-tape-upload.service: raise upload CPUquota (200% + Nice=10), change
--quote-sample-ms0 → 1000deployment/aliyun/polymarket-market-tape-upload.env: raiseZSTD_TIMEOUT_SECONDS300 → 3600,
OSS_COPY_TIMEOUT_SECONDS300 → 1800Issue relationship
None
Out of scope
The 8 GitHub workflow edits from the same stale local
mainwere notpreserved — verified
origin/mainalready contains all of them (de-sccache,timeout-minutes, permissions tightening, concurrency semantics).
Dependencies and merge order
None
Focused validation
git diff --check: cleanupstream conflict;
origin/maindoes not touch these paths)Rollout and rollback
Runtime-config only (Aliyun upload service/env). Rollback is reverting this PR.
Scope exception
None (7 files, well under the 25-file / 750-line split threshold).
Summary by CodeRabbit
Deployment
Documentation