Skip to content

chore(config): preserve local rules and deployment config edits on origin/main - #727

Merged
proerror77 merged 4 commits into
mainfrom
codex/preserve-config
Aug 7, 2026
Merged

chore(config): preserve local rules and deployment config edits on origin/main#727
proerror77 merged 4 commits into
mainfrom
codex/preserve-config

Conversation

@proerror77

@proerror77 proerror77 commented Aug 6, 2026

Copy link
Copy Markdown
Owner

Change contract

One behavior: preserve unique local edits from the (now-aligned) stale local
main that origin/main did not contain, rebased onto origin/main (4e1165c3).
All 7 files are small deletion/simplification or runtime-config deltas.

  • .claude/rules/datetime.md, standard-patterns.md, use-ast-grep.md:
    simplify internal rule docs
  • CLAUDE.md: trim Architecture / Focused Validation sections
  • deploy/docker-compose.yml: fix build context paths (../rust_hft..),
    require CLICKHOUSE_PASSWORD
  • deployment/aliyun/polymarket-market-tape-upload.service: raise upload CPU
    quota (200% + Nice=10), change --quote-sample-ms 0 → 1000
  • deployment/aliyun/polymarket-market-tape-upload.env: raise ZSTD_TIMEOUT_SECONDS
    300 → 3600, OSS_COPY_TIMEOUT_SECONDS 300 → 1800

Issue relationship

None

Out of scope

The 8 GitHub workflow edits from the same stale local main were not
preserved — verified origin/main already contains all of them (de-sccache,
timeout-minutes, permissions tightening, concurrency semantics).

Dependencies and merge order

None

Focused validation

  • git diff --check: clean
  • All 7 files verified identical to their pre-alignment local versions (no
    upstream conflict; origin/main does not touch these paths)

Rollout and rollback

Runtime-config only (Aliyun upload service/env). Rollback is reverting this PR.

Scope exception

None (7 files, well under the 25-file / 750-line split threshold).

Summary by CodeRabbit

  • Deployment

    • Secure configuration now requires an explicit database password instead of allowing an empty default.
    • Container builds use updated project paths for more reliable deployments.
    • Market-tape uploads have longer compression and storage-transfer timeouts.
    • Upload processing now uses a faster sampling interval and increased CPU allocation for improved throughput.
  • Documentation

    • Internal development guidance was streamlined by removing detailed implementation references, examples, and validation instructions.

…igin/main

Preserve unique local edits from stale main, rebased onto origin/main
(4e1165c). All are deletion/simplification or runtime config deltas that
origin/main does not have:

- .claude/rules/*.md: simplify datetime/standard-patterns/ast-grep rule docs
- CLAUDE.md: trim Architecture/Focused Validation sections
- deploy/docker-compose.yml: fix build context paths, require CLICKHOUSE_PASSWORD
- deployment/aliyun/polymarket-market-tape-upload.*: raise upload timeouts,
  CPUQuota 200% + Nice=10, quote-sample-ms 1000

Verified: git diff --check clean; all 7 files identical to local HEAD versions
(no upstream conflict).
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@coderabbitai

coderabbitai Bot commented Aug 6, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@proerror77, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 46 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 730e2ed8-f189-44ca-b94e-368c358dbd2f

📥 Commits

Reviewing files that changed from the base of the PR and between 3be425f and 047c998.

📒 Files selected for processing (1)
  • deployment/aliyun/polymarket-market-tape-upload.service
📝 Walkthrough

Walkthrough

The change removes detailed repository guidance and updates deployment configuration. Compose now requires a ClickHouse password and uses revised build paths. The tape-upload service receives longer timeouts, one-second quote sampling, and updated CPU and process-priority settings.

Changes

Repository guidance cleanup

Layer / File(s) Summary
Rule and repository guidance simplification
.claude/rules/*.md, CLAUDE.md
Removes detailed workflow examples, architecture inventories, validation commands, and tool references while retaining concise guidance.

Deployment configuration updates

Layer / File(s) Summary
Compose build and credential configuration
deploy/docker-compose.yml
Requires CLICKHOUSE_PASSWORD and changes collector, trader, and paper-trader builds to use the parent directory and deploy/Dockerfile.hft.
Tape-upload timing and service tuning
deployment/aliyun/polymarket-market-tape-upload.env, deployment/aliyun/polymarket-market-tape-upload.service
Increases upload timeouts, sets one-second quote sampling, removes selected explicit options, raises CPUQuota to 200%, and adds Nice=10.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes preserving local rule and deployment configuration edits on origin/main.
Description check ✅ Passed The description includes all required template sections and provides clear scope, validation, rollout, and rollback details.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/preserve-config

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@deployment/aliyun/polymarket-market-tape-upload.service`:
- Line 14: The tape-upload contract test must match the service’s updated
arguments. In deployment/aliyun/test-polymarket-market-tape-upload-contract.sh,
update the expected quote sampling value to 1000, revise the stale cutover
expectation, and explicitly verify whether --upload-concurrency 1 should be
retained or removed to match the intended ExecStart contract.
🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 9ff0b37b-a6d0-47bc-a9d3-d46fb7a93b6b

📥 Commits

Reviewing files that changed from the base of the PR and between b141bd2 and 3be425f.

📒 Files selected for processing (7)
  • .claude/rules/datetime.md
  • .claude/rules/standard-patterns.md
  • .claude/rules/use-ast-grep.md
  • CLAUDE.md
  • deploy/docker-compose.yml
  • deployment/aliyun/polymarket-market-tape-upload.env
  • deployment/aliyun/polymarket-market-tape-upload.service
💤 Files with no reviewable changes (2)
  • CLAUDE.md
  • .claude/rules/standard-patterns.md

Comment thread deployment/aliyun/polymarket-market-tape-upload.service Outdated
Sonic Shih added 2 commits August 7, 2026 22:43
…ontract

PR #727's ExecStart edit (quote-sample-ms 1000, drop ZSTD_THREADS/upload-concurrency)
violated test-polymarket-market-tape-upload-contract.sh, which pins the exact
main ExecStart. Revert ExecStart to main; keep the CPUQuota 200% + Nice=10
performance adjustment (not contract-checked).
@proerror77
proerror77 merged commit 2c78d13 into main Aug 7, 2026
50 checks passed
@proerror77
proerror77 deleted the codex/preserve-config branch August 7, 2026 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant