Skip to content

ci(acr-publish): carry bybit-options-archiver in the collector image - #740

Merged
proerror77 merged 2 commits into
mainfrom
codex/bybit-acr-pipeline
Aug 7, 2026
Merged

ci(acr-publish): carry bybit-options-archiver in the collector image#740
proerror77 merged 2 commits into
mainfrom
codex/bybit-acr-pipeline

Conversation

@proerror77

@proerror77 proerror77 commented Aug 7, 2026

Copy link
Copy Markdown
Owner

Summary

  • feat(bybit): governed options archiver with disk gate + bounded backoff #737 shipped the governed bybit-options-archiver bin, but the canonical ACR pipeline was never updated: Dockerfile.binance-lob-archiver built/installed only the five pre-existing collector binaries and the acr-publish.yml bare-metal extraction skipped the bybit binary, leaving the Bybit Options lane without a canonical build path.
  • Dockerfile: build --bin bybit-options-archiver with the same --locked --no-default-features flags, install to /out/bin, copy into the runtime image.
  • Workflow: extract artifact/bybit-options-archiver, verify --version binds needs.selector.outputs.source_sha, record bybit-options-archiver.sha256 with the other binaries.
  • Contract test: assert the image Dockerfile and workflow carry the bin, mirroring test-binance-usdm-reference-release-contract.sh.

Issue relationship

None

Validation

  • deployment/aliyun/test-bybit-options-release-contract.sh: pass (new ACR assertions included)
  • deployment/aliyun/test-binance-usdm-reference-release-contract.sh: pass
  • deployment/aliyun/test-rust-lob-control-plane.sh: pass
  • git diff --check clean; acr-publish.yml parses as YAML

Summary by CodeRabbit

  • New Features

    • Added the Bybit options archiver to the release and container images.
    • Included version metadata and SHA-256 checksum verification for the new binary.
  • Tests

    • Expanded release validation to confirm the binary is built, packaged, checksummed, and published correctly.

#737 added the governed bybit-options-archiver bin but the canonical
ACR pipeline never learned about it: the image Dockerfile built and
installed only the five pre-existing collector binaries, and the
publish workflow's bare-metal artifact extraction skipped the bybit
binary entirely. Without this the governed Bybit Options lane has no
canonical build path.

- Dockerfile.binance-lob-archiver: build --bin bybit-options-archiver
  with the same --locked --no-default-features flags, install to
  /out/bin, and copy into the runtime image
- acr-publish.yml: extract artifact/bybit-options-archiver, verify its
  --version binds the source revision, and record its sha256 alongside
  the other binaries
- test-bybit-options-release-contract.sh: assert the image and
  workflow carry the bin, mirroring the usdm-reference contract test
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@coderabbitai

coderabbitai Bot commented Aug 7, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@proerror77, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 54 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 70fab241-80f4-40eb-97e2-63892a62fad4

📥 Commits

Reviewing files that changed from the base of the PR and between 10a440e and 1cc15d2.

📒 Files selected for processing (1)
  • deployment/aliyun/test-bybit-options-release-contract.sh
📝 Walkthrough

Walkthrough

Changes

Bybit options archiver release

Layer / File(s) Summary
Build and install the archiver
rust_hft/deployment/docker/Dockerfile.binance-lob-archiver
The Docker builder compiles and installs bybit-options-archiver. The runtime image copies it to /usr/local/bin/bybit-options-archiver.
Package and validate the release artifact
.github/workflows/acr-publish.yml, deployment/aliyun/test-bybit-options-release-contract.sh
The ACR workflow extracts the binary, verifies its version, and generates its SHA-256 checksum. The release contract test checks the build, packaging, checksum, and publication references.

Estimated code review effort: 2 (Simple) | ~10 minutes

Sequence Diagram(s)

sequenceDiagram
  participant DockerImage
  participant ACRWorkflow
  participant ReleaseContract
  DockerImage->>ACRWorkflow: provide bybit-options-archiver
  ACRWorkflow->>ACRWorkflow: verify version and generate checksum
  ReleaseContract->>ACRWorkflow: verify build and publication references
Loading

Possibly related PRs

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description explains the change and validation, but it omits the required Change contract, Out of scope, Dependencies, Rollout, and Scope exception sections. Add all required template sections and state the behavior, reason, out-of-scope work, dependencies, rollout and rollback impact, and scope exception status.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the ACR publishing change and the addition of the bybit-options-archiver binary.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/bybit-acr-pipeline

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@proerror77
proerror77 merged commit b141bd2 into main Aug 7, 2026
50 checks passed
@proerror77
proerror77 deleted the codex/bybit-acr-pipeline branch August 7, 2026 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant