ci(acr-publish): carry bybit-options-archiver in the collector image - #740
Conversation
#737 added the governed bybit-options-archiver bin but the canonical ACR pipeline never learned about it: the image Dockerfile built and installed only the five pre-existing collector binaries, and the publish workflow's bare-metal artifact extraction skipped the bybit binary entirely. Without this the governed Bybit Options lane has no canonical build path. - Dockerfile.binance-lob-archiver: build --bin bybit-options-archiver with the same --locked --no-default-features flags, install to /out/bin, and copy into the runtime image - acr-publish.yml: extract artifact/bybit-options-archiver, verify its --version binds the source revision, and record its sha256 alongside the other binaries - test-bybit-options-release-contract.sh: assert the image and workflow carry the bin, mirroring the usdm-reference contract test
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Warning Review limit reached
Next review available in: 54 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughChangesBybit options archiver release
Estimated code review effort: 2 (Simple) | ~10 minutes Sequence Diagram(s)sequenceDiagram
participant DockerImage
participant ACRWorkflow
participant ReleaseContract
DockerImage->>ACRWorkflow: provide bybit-options-archiver
ACRWorkflow->>ACRWorkflow: verify version and generate checksum
ReleaseContract->>ACRWorkflow: verify build and publication references
Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
bybit-options-archiverbin, but the canonical ACR pipeline was never updated:Dockerfile.binance-lob-archiverbuilt/installed only the five pre-existing collector binaries and theacr-publish.ymlbare-metal extraction skipped the bybit binary, leaving the Bybit Options lane without a canonical build path.--bin bybit-options-archiverwith the same--locked --no-default-featuresflags, install to/out/bin, copy into the runtime image.artifact/bybit-options-archiver, verify--versionbindsneeds.selector.outputs.source_sha, recordbybit-options-archiver.sha256with the other binaries.test-binance-usdm-reference-release-contract.sh.Issue relationship
None
Validation
deployment/aliyun/test-bybit-options-release-contract.sh: pass (new ACR assertions included)deployment/aliyun/test-binance-usdm-reference-release-contract.sh: passdeployment/aliyun/test-rust-lob-control-plane.sh: passgit diff --checkclean;acr-publish.ymlparses as YAMLSummary by CodeRabbit
New Features
Tests