fix(collector): bind Polymarket binary to source revision - #391
Conversation
📝 WalkthroughWalkthroughThe change binds ChangesPolymarket source revision binding
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related issues
Possibly related PRs
Sequence Diagram(s)sequenceDiagram
participant GitHubActions
participant EvidenceCompilerImage
participant PolymarketRawOps
GitHubActions->>EvidenceCompilerImage: Build with SOURCE_REVISION
EvidenceCompilerImage->>PolymarketRawOps: Compile with MONDAY_SOURCE_REVISION
GitHubActions->>PolymarketRawOps: Run --version
PolymarketRawOps-->>GitHubActions: Return embedded source revision
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 78a2542e68
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Change contract
Bind every published
polymarket-raw-opsartifact identity to the exact compile-timeMONDAY_SOURCE_REVISION, and fail CI or ACR publication unless--versionmatches the selected source SHA.Out of scope
Collector data behavior, Gate recovery semantics, production cutover, snapshot/research logic, and #235.
Dependency / merge order
Depends on #389 already merged at
e93319412d73fb5c041040d0e7cf7af0321100df. This PR must merge before building the next exact-main Polymarket Gate candidate.Focused validation
cargo test -p hft-collector --bin polymarket-raw-ops— 5 passed.cargo clippy -p hft-collector --bin polymarket-raw-ops --no-deps -- -D warnings— passed.polymarket-raw-ops e93319412d73fb5c041040d0e7cf7af0321100df.--versionoutput..github/scripts/test-acr-publish-workflow.sh— passed.git diff --check— passed.cargo fmt --all -- --checkremains blocked by pre-existing unrelated formatting drift; this PR does not reformat unrelated code.Rollout / rollback impact
After merge, rebuild the exact-main
binance-lob-archiverartifact and require the Polymarket candidate SHA to differ from the already pinned9aeca5caf148b7770657b2e1017cce3f72e6bfc26e492bc63e4cc06b585d3340before starting a new formal Shadow Gate. Rollback is reverting this source-identity change; no production service is changed by this PR.Closes #390