-
Notifications
You must be signed in to change notification settings - Fork 229
Team page update2020 #1918
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Team page update2020 #1918
Conversation
|
What this pull request does:
@jenniferisasi this is ready for your review or for discussion (I can meet on a Friday of your choosing if that's easier). I think this is a simpler and easier to maintain version of the page. |
|
@acrymble thanks for all the work with this. One question: is it possible to change my photo using this branch? |
|
@DanielAlvesLABDH yes can you email it to me? @jenniferisasi I realised this change leaves @JMParr not appearing. We may have to think where she will go on this. |
|
@walshbr @amsichani a query for you both as I try to work out how best to represent the "Publisher" team on the /project-team page. I've amended this in the pull request to only include the ProgHist Ltd team (since a number of us aren't on individual publication teams) but this leaves out Jess who is only on the Global Team. What I want to avoid is a meaninglessly large "Publisher" team listing. If I were to include the Proghist team and the "team leaders" of Global, Comms, and Tech, would the two of you feel left out or otherwise slighted, since it didn't list you too? The "technical" tag still appears next to your name in your respective publication. Please be honest. I'm just looking for the most accurate but also least verbose way of representing our project team. |
|
Is that because we're the only non-leaders on the ProgHist LTD group that are also elsewhere in the project? I'm not sure it matters to me too much. I appreciate you asking, but it feels like it's largely an internal bureaucratic question. I'm not sure it matters to me how it gets represented to the public in this instance. |
1, 2 and 3: good idea! I liked to see what each of us work on but it is true that it poses a burden on translation on any updates of the profiles. @acrymble my only recommendation here is that we keep the way we had to go directly to a team or, alternatively, that we create an |
|
@jenniferisasi I put the table of contents back and I've added in the team leads to the "ProgHist Ltd" team (which is not strinctly accurate but gets the right message across to readers I think). I think this is ready if you're happy with it. |
|
Looking much better now, @acrymble thanks for incorporating the table back. I am wondering if we want to already Daniel Alves on the first "Please direct correspondence in the first instance to:" ? |
|
@jenniferisasi the logic for adding Daniel is linked to adding the PT pages officially to the site. So that will automatically happen when the tech team finishes the PT integration. |
I see, makes sense. I should have checked the code/page, as I assumed it was just written in there. |
This is a big update to the various role labels people hold for the Project Team page, which was getting quite out of date. It includes adding 2 new members and tweaking a few things so people hopefully have fewer tags next to their names to reflect duplication.
Not ready for review yet.
Checklist
Closes #ISSUENUMBERto the description aboveIf you are having difficulty fixing Travis errors, first consult https://github.com/programminghistorian/jekyll/wiki/Making-Technical-Contributions carefully, especially "Common Travis Errors". Then contact the technical team if you need further help.