Skip to content

Conversation

@acrymble
Copy link

@acrymble acrymble commented Oct 16, 2020

This is a big update to the various role labels people hold for the Project Team page, which was getting quite out of date. It includes adding 2 new members and tweaking a few things so people hopefully have fewer tags next to their names to reflect duplication.

Not ready for review yet.

Checklist

If you are having difficulty fixing Travis errors, first consult https://github.com/programminghistorian/jekyll/wiki/Making-Technical-Contributions carefully, especially "Common Travis Errors". Then contact the technical team if you need further help.

@acrymble acrymble self-assigned this Oct 16, 2020
@acrymble
Copy link
Author

What this pull request does:

  1. Updates all team members to their current agreed roles. Removes some duplication (eg ME no longer listed as ME + Editor).
  2. Updates bios, photos, and affiliations, etc, as required.
  3. Changes the display from bio to affiliation. This means the page can be updated without the need for translation in future, which reduces translation burden and eases burden of new teams.
  4. Removes "Impact Manager" role, which was never filled.
  5. Removes the long lists of contributors from the project page (I originally tried moving this to the /supporters page but it made it look messy and we just redid that page).
  6. Removes the authors_loop.html and collaborators_loop.html includes, which were used in 5.

@jenniferisasi this is ready for your review or for discussion (I can meet on a Friday of your choosing if that's easier).

I think this is a simpler and easier to maintain version of the page.

@DanielAlvesLABDH
Copy link
Contributor

@acrymble thanks for all the work with this. One question: is it possible to change my photo using this branch?

@acrymble
Copy link
Author

@DanielAlvesLABDH yes can you email it to me?

@jenniferisasi I realised this change leaves @JMParr not appearing. We may have to think where she will go on this.

@acrymble
Copy link
Author

@walshbr @amsichani a query for you both as I try to work out how best to represent the "Publisher" team on the /project-team page.

I've amended this in the pull request to only include the ProgHist Ltd team (since a number of us aren't on individual publication teams) but this leaves out Jess who is only on the Global Team. What I want to avoid is a meaninglessly large "Publisher" team listing. If I were to include the Proghist team and the "team leaders" of Global, Comms, and Tech, would the two of you feel left out or otherwise slighted, since it didn't list you too? The "technical" tag still appears next to your name in your respective publication.

Please be honest. I'm just looking for the most accurate but also least verbose way of representing our project team.

@walshbr
Copy link
Contributor

walshbr commented Oct 22, 2020

Is that because we're the only non-leaders on the ProgHist LTD group that are also elsewhere in the project? I'm not sure it matters to me too much. I appreciate you asking, but it feels like it's largely an internal bureaucratic question. I'm not sure it matters to me how it gets represented to the public in this instance.

@jenniferisasi
Copy link
Contributor

What this pull request does:

  1. Updates all team members to their current agreed roles. Removes some duplication (eg ME no longer listed as ME + Editor).
  2. Updates bios, photos, and affiliations, etc, as required.
  3. Changes the display from bio to affiliation. This means the page can be updated without the need for translation in future, which reduces translation burden and eases burden of new teams.
  4. Removes "Impact Manager" role, which was never filled.
  5. Removes the long lists of contributors from the project page (I originally tried moving this to the /supporters page but it made it look messy and we just redid that page).
  6. Removes the authors_loop.html and collaborators_loop.html includes, which were used in 5.

@jenniferisasi this is ready for your review or for discussion (I can meet on a Friday of your choosing if that's easier).

I think this is a simpler and easier to maintain version of the page.

1, 2 and 3: good idea! I liked to see what each of us work on but it is true that it poses a burden on translation on any updates of the profiles.
4 and 6: fine as well.
5. Is this going to still be somewhere?

@acrymble my only recommendation here is that we keep the way we had to go directly to a team or, alternatively, that we create an if condition by which teams are moved to the top depending on the language of the page. Not the end of the world if we don't have that, but from a user perspective I think it can be frustrating to have to scroll like that, and the list will only but get longer soon (thinking FR team recruitment)

@acrymble
Copy link
Author

@jenniferisasi I put the table of contents back and I've added in the team leads to the "ProgHist Ltd" team (which is not strinctly accurate but gets the right message across to readers I think). I think this is ready if you're happy with it.

@jenniferisasi
Copy link
Contributor

Looking much better now, @acrymble thanks for incorporating the table back.

I am wondering if we want to already Daniel Alves on the first "Please direct correspondence in the first instance to:" ?

@acrymble
Copy link
Author

@jenniferisasi the logic for adding Daniel is linked to adding the PT pages officially to the site. So that will automatically happen when the tech team finishes the PT integration.

@jenniferisasi
Copy link
Contributor

@jenniferisasi the logic for adding Daniel is linked to adding the PT pages officially to the site. So that will automatically happen when the tech team finishes the PT integration.

I see, makes sense. I should have checked the code/page, as I assumed it was just written in there.

@acrymble acrymble merged commit 3144a0b into gh-pages Oct 24, 2020
@acrymble acrymble deleted the teamPageUpdate2020 branch October 24, 2020 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants