Skip to content

Conversation

@fdlaramee
Copy link
Contributor

@fdlaramee fdlaramee commented Oct 21, 2020

A user had trouble reproducing the results in the tutorial because they had skipped one of the methods and moved straight to the second or third. I added a warning that users who want to do that must make sure to copy-paste the preprocessing code from the method(s) they skip if they want to obtain the same results that I do.

Checklist

If you are having difficulty fixing Travis errors, first consult https://github.com/programminghistorian/jekyll/wiki/Making-Technical-Contributions carefully, especially "Common Travis Errors". Then contact the technical team if you need further help.

@fdlaramee fdlaramee requested review from a team October 21, 2020 14:32
@fdlaramee fdlaramee self-assigned this Oct 21, 2020
@fdlaramee
Copy link
Contributor Author

fdlaramee commented Oct 21, 2020

Hi @programminghistorian/technical-team ; I don't understand why this build fails; it reports broken links in three documents that I haven't changed; help please!

@walshbr
Copy link
Contributor

walshbr commented Oct 21, 2020

Travis checks for URLs that are broken, and it checks the whole site - not just the pages you changed. So those are URLs that have gone down since we last built things. Even if you didn't change those pages, we generally have a policy that the person who finds the broken links fixes them as a part of the same PR. If they're not easily fixed because the resources can't be found in the past I think we've removed those links and said as much in a little emendation in the text.

@jenniferisasi
Copy link
Contributor

Hi @programminghistorian/technical-team ; I don't understand why this build fails; it reports broken links in three documents that I haven't changed; help please!

Every time we run anything, Travis looks for errors all over the site; so this is totally normal @fdlaramee :)

It is weirder however that two of the links are actually working when I checked now.

@walshbr
Copy link
Contributor

walshbr commented Oct 21, 2020

If that's the case you can click "re-run" next to the place where you click "build" to see the errors. I just reset. Sometimes things happen to be down temporarily when Travis runs.

@walshbr
Copy link
Contributor

walshbr commented Oct 21, 2020

Things seem fine now. (and FWIW in case you went looking, it looks like the "re-run" button disappears when the travis checks pass - I swear it was there five minutes ago).

* Les rudiments du [Natural Language Toolkit (documentation en anglais)](https://www.nltk.org/) (nltk), un module Python populaire dédié au [traitement du langage naturel](https://fr.wikipedia.org/wiki/Traitement_automatique_du_langage_naturel).

<div class="alert alert-warning">
Veuillez noter que le code informatique de cette leçon a été conçu pour être exécuté en séquence. Si, par exemple, vous désirez passer outre la méthode de Mendenhall et vous diriger directement vers celle de Klgariff ou celle de Burrows, veuillez vous assurer de copier-coller les instructions de pré-traitement qui apparaissent dans la description de la méthode de Mendenhall vers votre propre bloc de code. Sinon, vous n'obtiendrez pas exactement les résultats présentés ici.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

petite coquille dans 'Kilgariff'

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merci @mariechristineb c'est réglé.

@fdlaramee fdlaramee merged commit 504e891 into gh-pages Oct 30, 2020
@fdlaramee fdlaramee deleted the issue-1883 branch October 30, 2020 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants