Skip to content

Conversation

@walshbr
Copy link
Contributor

@walshbr walshbr commented Jan 20, 2021

Closes #1776. Needs translation into Fr, Es, Pt. It should be ready to be translated.

Checklist

If you are having difficulty fixing Travis errors, first consult https://github.com/programminghistorian/jekyll/wiki/Making-Technical-Contributions carefully, especially "Common Travis Errors". Then contact the technical team if you need further help.

@walshbr walshbr changed the title Update guidelines Update guidelines re: DOI Jan 20, 2021
@walshbr walshbr requested review from a team January 20, 2021 17:06
@walshbr walshbr self-assigned this Jan 20, 2021
@walshbr
Copy link
Contributor Author

walshbr commented Jan 20, 2021

Ready for translation @programminghistorian/french-team @programminghistorian/spanish-team @programminghistorian/portuguese-team! Let me know if you have any questions.

rivaquiroga
rivaquiroga previously approved these changes Jan 20, 2021
@walshbr
Copy link
Contributor Author

walshbr commented Jan 21, 2021

@rivaquiroga - were you done with your changes? If so, I think the @programminghistorian/french-team review is the only one outstanding.

@rivaquiroga
Copy link
Member

@walshbr, yes, I'm done.
My approval went stale after Daniel's commits.

rivaquiroga
rivaquiroga previously approved these changes Jan 21, 2021
@walshbr walshbr merged commit 13f4c53 into gh-pages Jan 21, 2021
@walshbr walshbr deleted the add-doi-workflow-to-guidelines branch January 21, 2021 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update Editor Guidelines: DOI workflow

5 participants