Skip to content

Conversation

@anisa-hawes
Copy link
Contributor

@anisa-hawes anisa-hawes commented Sep 16, 2021

I am updating en/lessons/visualizing-with-bokeh to add an information alert box which clarifies the options readers have at the Running Code Examples step.

Additionally, I am replacing links which direct to assets in the Submissions Repository, with links which direct to assets in Jekyll.

Closes #1662

Checklist

  • Assign yourself in the "Assignees" menu
  • Assign at least one individual or team to "Reviewers"
    • if the text needs to be translated, assign the relevant language team(s) as "Reviewers" and tag both the team as well as the managing edtor in your PR. Please follow the translation request guidelines when writing your PR description
  • Add the appropriate "Label"
  • Ensure the status checks pass
  • Check the live preview of your PR on Netlify
  • If this PR closes an open issue, add the phrase Closes #ISSUENUMBER to the description above

If you are having difficulty fixing build errors, first consult https://github.com/programminghistorian/jekyll/wiki/Making-Technical-Contributions carefully, especially "Common Build Errors". Then contact the technical team if you need further help.

I am updating `en/lessons/visualizing-with-bokeh` with a suggestion for an information alert box.
I am updating `en/lessons/visualizing-with-bokeh` to replace links which direct to assets in the Submissions Repository, with links which direct to the assets directory in Jekyll.
I am correcting the links to assets in the Jekyll repository, replacing `raw.githubusercontent.com` with `github.com` in the URLs.
I am removing full links to data assets in our GitHub repositories and replacing with relative paths starting "/"
@anisa-hawes anisa-hawes requested review from svmelton and removed request for svmelton September 16, 2021 16:44
@anisa-hawes
Copy link
Contributor Author

Hello @svmelton. Are you able to Review this for me? The alert box I've added is built with Bootstrap and doesn't render in the GitHub or netlify previews (html tags are exposed), but I'm fairly confident that the formatting is correct. Thank you!

@svmelton
Copy link
Contributor

Hello @svmelton. Are you able to Review this for me? The alert box I've added is built with Bootstrap and doesn't render in the GitHub or netlify previews (html tags are exposed), but I'm fairly confident that the formatting is correct. Thank you!

Hmm, that's strange. I don't think it should make a difference, but have you tried it using straight quotation marks (") rather than the "smart" ones (“)?

The other alert boxes don't seem to have an issue with links. If it isn't the character issue that I mentioned above, I wonder if it has something to do with using relative links in the alert boxes. Tagging the @programminghistorian/technical-team in case they've seen anything like this before.

I am replacing “ with " in the alert/information box
@anisa-hawes
Copy link
Contributor Author

Wonderful! Thank you, @svmelton!

@anisa-hawes anisa-hawes merged commit d19aeb7 into gh-pages Sep 16, 2021
@anisa-hawes anisa-hawes deleted the Issue-1662 branch September 16, 2021 17:33
@anisa-hawes anisa-hawes restored the Issue-1662 branch October 1, 2021 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implementing paths in Visualizing Data with Bokeh and Pandas

3 participants