Skip to content

Conversation

@anisa-hawes
Copy link
Contributor

@anisa-hawes anisa-hawes commented Nov 3, 2021

I am updating the initial contact information on the Research pages of our website, so that our MEs are no longer listed as first point of contact for academic researchers using the project and my contact information is given instead.

research.md
investigacion.md
recherche.md
pesquisa.md

Closes #2351

Checklist

  • Assign yourself in the "Assignees" menu
  • Assign at least one individual or team to "Reviewers"
    • if the text needs to be translated, assign the relevant language team(s) as "Reviewers" and tag both the team as well as the managing editor in your PR. Please follow the translation request guidelines when writing your PR description
  • Add the appropriate "Label"
  • Ensure the status checks pass
  • Check the live preview of your PR on Netlify
  • If this PR closes an open issue, add the phrase Closes #ISSUENUMBER to the description above

If you are having difficulty fixing build errors, first consult https://github.com/programminghistorian/jekyll/wiki/Making-Technical-Contributions carefully, especially "Common Build Errors". Then contact the technical team if you need further help.

Paragraph 8. Updating contact to [Anisa Hawes](anisa.hawes@icloud.com)
Paragraph 8. Updating contact to [Anisa Hawes](anisa.hawes@icloud.com)
adding the words "our publishing assistant"
Paragraph 8. Updating contact to [Anisa Hawes](anisa.hawes@icloud.com)
Paragraph 8. Updating contact to [Anisa Hawes](anisa.hawes@icloud.com)
@anisa-hawes anisa-hawes self-assigned this Nov 3, 2021
@jenniferisasi
Copy link
Contributor

@DanielAlvesLABDH in Portuguese it should say "nossa asistente", right?

And @anisa-hawes call for help if you receive any of those emails in ES, FR or PT :)

@anisa-hawes
Copy link
Contributor Author

anisa-hawes commented Nov 3, 2021

Ah! Thank you, @jenniferisasi!

I was thinking 'nosso' because we at PH are a mixed group, but as I am then identifying myself (female) it should be 'nossa'.

I am learning every day!

Correcting gender of possessive pronoun `nossa`.
@jenniferisasi
Copy link
Contributor

I don't understand the error...

- ./_site/en/research.html
  *  internally linking to anisa.hawes@icloud.com, which does not exist (line 240)
     <a href="anisa.hawes@icloud.com">Anisa Hawes</a>

There is no line 240 in the research page; and the link is not formatted as <a href= in the pages you are editing here... I'll investigate.

@anisa-hawes
Copy link
Contributor Author

Oh dear. Thank you, @jenniferisasi. I did note that the original links to generate emails to the MEs were formatted like this, {% include managing-editor.html lang=page.lang %} but I thought it would be possible to replace that with a link formatted as Markdown...

@jenniferisasi
Copy link
Contributor

Yes, that is a liquid loop (maybe that's not their tech name) that calls to _includes/managing-editor.html, that looks into snippets to find the name of the managing editor based on the language the page is in (that corresponds to the folder where the .md is in).

used the href tag
@anisa-hawes
Copy link
Contributor Author

Okay. Thank you, @jenniferisasi. If this works, I can do the same for the other three pages.

@jenniferisasi
Copy link
Contributor

@anisa-hawes looks like my fix on the EN page worked. So you have to change the markdown type links to html links like this: <a href="mailto:anisa.hawes@icloud.com">Anisa Hawes</a>.

anisa-hawes and others added 4 commits November 3, 2021 14:34
Replacing Markdown links with href tag.
Replacing Markdown links with href tag.
Replacing Markdown links with href tag.
A small change... 
Thank you Anisa and Jennifer. In Portuguese the gender is always explicitly mention. In this case I have just included the "a" before "nossa". It's not mandatory but it is more correct.
@anisa-hawes
Copy link
Contributor Author

Thank you, @DanielAlvesLABDH & @jenniferisasi!

@anisa-hawes anisa-hawes merged commit 35de8f3 into gh-pages Nov 3, 2021
@anisa-hawes anisa-hawes deleted the Issue-2351 branch November 3, 2021 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Updating initial contact information on Research pages

4 participants