Skip to content

Conversation

@anisa-hawes
Copy link
Contributor

@anisa-hawes anisa-hawes commented Mar 10, 2023

I am adding alert-warning boxes to the following lessons to help readers avoid a potential security exploit:

  • /en/lessons/building-static-sites-with-jekyll-github-pages
  • /es/lecciones/sitios-estaticos-con-jekyll-y-github-pages
  • /en/lessons/collaborative-blog-with-jekyll-github

Dear @rivaquiroga and @jenniferisasi,

I would be grateful for your help to check/correct my Spanish translation of the warning text:

<div class="alert alert-warning">
If you set up a custom domain with your GitHub Pages-hosted website, to avoid a known security exploit please make sure to also read and follow the steps in <a href='https://docs.github.com/en/pages/configuring-a-custom-domain-for-your-github-pages-site/verifying-your-custom-domain-for-github-pages'>GitHub’s documentation</a> to both verify your domain and avoid using wildcard DNS records.
</div>
<div class="alert alert-warning">
Si configuras un dominio personalizado con tu sitio web alojado en GitHub Pages, para evitar un fallo de seguridad conocido, asegúrate de leer y seguir los pasos de <a href='https://docs.github.com/en/pages/configuring-a-custom-domain-for-your-github-pages-site/verifying-your-custom-domain-for-github-pages'>la documentación de GitHub</a> para verificar tu dominio y evitar el uso de registros DNS comodín.
</div>

With thanks, Anisa


Closes #2874

Checklist

  • Assign yourself in the "Assignees" menu
  • Add the appropriate "Label"
  • If this PR closes an Issue, add the phrase Closes #ISSUENUMBER to your summary above
  • Ensure the status checks pass: if you have difficulty fixing build errors, please contact our Publishing Assistant @anisa-hawes
  • Check the Netlify Preview: navigate to netlify/ph-preview/deploy-preview and click 'details' (at right)
  • Assign at least one individual or team to "Reviewers"
    • if the text needs to be translated, please follow the translation request guidelines, then assign the relevant language team(s) as "Reviewers" and tag both the team as well as the managing editor in your PR.

anisa-hawes and others added 4 commits March 10, 2023 21:05
@rivaquiroga
Copy link
Member

Done!

@anisa-hawes anisa-hawes merged commit 34fc761 into gh-pages Mar 11, 2023
@anisa-hawes anisa-hawes deleted the Issue-2874 branch March 11, 2023 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add lesson footnote to avoid potential security exploit?

3 participants