Skip to content

fix: standardize timer duration formatting - #768

Merged
gaidheal1 merged 8 commits into
progressrpg:developmentfrom
Harshit15-coder:main
Aug 13, 2026
Merged

fix: standardize timer duration formatting#768
gaidheal1 merged 8 commits into
progressrpg:developmentfrom
Harshit15-coder:main

Conversation

@Harshit15-coder

Copy link
Copy Markdown

##Summary
-Replaced duplicated time formatting with formatDuration
--Fixed timer display for durations over 1 hour
-Updated related timer components
-All 69 tests pass

gaidheal1 and others added 8 commits August 8, 2026 15:54
storybook build has no --base option (that's Vite-only), so the
build-storybook step has been failing on every push to main since the
mkdocs conversion, leaving the deployed site stuck on a stale
pre-mkdocs Storybook-only build. The base path is already set via
viteFinal in .storybook/main.ts, so the flag was redundant anyway.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01QSwWkchRGye37hoCmEfDCz
…ld-base-flag

Fix GitHub Pages docs deploy: remove invalid storybook --base flag
react-docgen's resolveToValue recurses infinitely on a let variable that
is conditionally assigned and then reassigned multiple times, causing
"Maximum call stack size exceeded" during `npm run build-storybook`.
Compute API_BASE_URL once via a helper instead of reassigning it.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
…gen-stack-overflow

Fix Storybook build: react-docgen stack overflow in config.ts
@gaidheal1
gaidheal1 changed the base branch from main to development August 12, 2026 14:19
@gaidheal1
gaidheal1 self-requested a review August 13, 2026 15:37

@gaidheal1 gaidheal1 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for your PR @Harshit15-coder 🙌

@gaidheal1
gaidheal1 merged commit 4982652 into progressrpg:development Aug 13, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use formatDuration util for timer display instead of duplicated mm:ss formatting

2 participants