Search menu #405
Merged
Search menu #405
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
revmischa
reviewed
Aug 15, 2020
| * Cmd/Ctrl-M: change *m*onitor | ||
| * Cmd/Ctrl-F: toggle *f*ull screen | ||
| * Mouse Scroll Up / Down: next or previous preset (hard transition) | ||
| * Return: search for preset (RETURN or ESCAPE to exit search) |
Collaborator
Author
There was a problem hiding this comment.
I started with this but gave up because of how SDL_StartTextInput will still grab the / key. I am likely missing something, but this could be a wish list.
src/libprojectM/KeyHandler.cpp
Outdated
| { | ||
| case PROJECTM_K_HOME: | ||
| if (renderer->showmenu) { // pageup only does something when the preset menu is active. | ||
| if (renderer->showmenu && !isTextInputActive()) { // pageup only does something when the preset menu is active. |
Member
There was a problem hiding this comment.
these could be all simplified to if (isTextInputActive()) break;
src/libprojectM/PresetLoader.cpp
Outdated
| const unsigned int PresetLoader::getPresetIndex(std::string &name) const | ||
| { | ||
| //Need a better structure than a vector for reverse lookup | ||
| for (int index = 0; index < _presetNames.size(); index++) |
Member
There was a problem hiding this comment.
is there an indexOf() method or something like that in Vector?
| else { | ||
| if (highlightable && showsearch && searchText().length() > 1) | ||
| { | ||
| int offset = x; |
Member
There was a problem hiding this comment.
can these be separate functions?
| { | ||
| int offset = x; | ||
| std::string str_find = substring; | ||
| for (size_t pos = 0; ; pos += str_find.length()) { |
Member
There was a problem hiding this comment.
refactor with above to function?
This reverts commit f8cea68.
milkdropper
force-pushed
the
search
branch
2 times, most recently
from
768cbfa to
71ea3b8
Compare
Return enters search menu. Return/Escape exits search menu.
search based on text update next / previous based on search results.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhancement to the preset navigation menu previously submitted. Hit return and start typing to filter to presets based on keyword (case sensitive). It's limited to a single page for now (hopefully good enough).
obligatory demo: https://streamable.com/f8gbf1