Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes almost all warnings in the codebase when compiling on Linux under gcc 9.3.
Only one I couldn't figure out, which is possibly a false compiler warning, is
It complains about
activePresetIdbeing uninitialized, however it's a class instance and the default constructor is called.activePresetId.value()above won't be called if it's never been assigned (ashasValue()only returns true ifoperator=has been called).