install additional headers needed to compile against libprojectm #53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
revmischa
reviewed
Apr 10, 2018
Makefile.am
Outdated
| src/libprojectM/Renderer/projectM.cg | ||
|
|
||
| # system headers/libraries/data to install | ||
| include_HEADERS = config.h |
Member
There was a problem hiding this comment.
revmischa
reviewed
Apr 10, 2018
|
|
||
| # system headers/libraries/data to install | ||
| include_HEADERS = projectM.hpp | ||
| include_HEADERS = projectM.hpp Common.hpp dlldefs.h event.h fatal.h PCM.hpp |
Contributor
Author
There was a problem hiding this comment.
So Common.hpp includes config.h as of 4/5. Commit log says "Add FTGL configure flag". I can remove config.h from Common.hpp but I would break whatever was being tried with the FTGL configure flag. For places that need this flag, could we include config.h at the lower level files?
Member
There was a problem hiding this comment.
I think that sounds like a fine idea, yes 👍
Member
There was a problem hiding this comment.
Merged
Merged
revmischa
added a commit
that referenced
this pull request
Nov 16, 2019
install additional headers needed to compile against libprojectm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
install additional headers needed to compile against libprojectm