Skip to content

Add Ansible Tower (AWX)#1685

Merged
brian-brazil merged 2 commits into
prometheus:masterfrom
bryanasdev000:master
Jun 25, 2020
Merged

Add Ansible Tower (AWX)#1685
brian-brazil merged 2 commits into
prometheus:masterfrom
bryanasdev000:master

Conversation

@bryanasdev000

Copy link
Copy Markdown
Contributor

Include Ansible Tower (AWX) as a "Software exposing Prometheus metrics" with direct link to the documentation.

Signed-off-by: Bryan A. S <bryanasdev000@gmail.com>
Signed-off-by: Bryan A. S <bryanasdev000@gmail.com>
@brian-brazil
brian-brazil merged commit 6fbea43 into prometheus:master Jun 25, 2020
@brian-brazil

Copy link
Copy Markdown
Contributor

Thanks!

From a quick peek at the code I noticed that metric names are being procedurally generated: https://github.com/ansible/awx/blob/def3114b5bc817999d466920a4c82c33f2167608/awx/main/analytics/broadcast_websocket.py#L121
That should be a label instead.

@bryanasdev000

Copy link
Copy Markdown
Contributor Author

@brian-brazil soo I don't understand too much from dev point of view of Prometheus, but based on your response, opening a issue to check this at Tower upstream is a good idea, right?

@brian-brazil

Copy link
Copy Markdown
Contributor

Yes it would be. Usually the authors of PRs to add to this list are also the authors of the code, so I provide some feedback in passing to help everyone get good metrics.

@bryanasdev000

Copy link
Copy Markdown
Contributor Author

@brian-brazil , OK, I will get some sleep, do some research on this topic and open a issue at AWX repo for check it. Thank you!

@bryanasdev000

Copy link
Copy Markdown
Contributor Author

For the records, I have opened issue #7446 at AWX repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants