Call accept_handler before append_to_history in Buffer.validate_and_handle - #800
Merged
jonathanslenders merged 1 commit intoDec 7, 2018
Merged
Conversation
…andle This was a regression from 6cfc3f3. Without this, any changes made to the buffer text in the accept handler are not reflected in the history. For instance, I call dedent(text).strip() in the accept handler.
Codecov Report
@@ Coverage Diff @@
## master #800 +/- ##
=======================================
Coverage 70.79% 70.79%
=======================================
Files 140 140
Lines 13251 13251
=======================================
Hits 9381 9381
Misses 3870 3870
Continue to review full report at Codecov.
|
Member
|
Thank you @asmeurer, for creating this pull request! This makes sense. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was a regression from 6cfc3f3.
Without this, any changes made to the buffer text in the accept handler are
not reflected in the history. For instance, I call dedent(text).strip() in the
accept handler.