Document the dotnet/nbgv @master no-SHA-pin rule#223
Merged
Conversation
nbgv already floats @master here; add the inline rationale comment and the AGENTS.md rule so the no-SHA-pin exception is explicit and converged across the fleet (the tag stream lags master, so a pin draws spurious Dependabot downgrade PRs). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR documents the existing exception to the repository’s GitHub Actions SHA-pinning convention for dotnet/nbgv, making the rationale explicit in both the agent guidance (AGENTS.md) and the relevant workflow.
Changes:
- Add an explicit rule in
AGENTS.mdstatingdotnet/nbgvshould remain on@master(not SHA-pinned) due to upstream tag lag and Dependabot downgrade noise. - Add an inline workflow comment in
build-release-task.ymlexplaining whydotnet/nbgv@masteris intentionally floated.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| AGENTS.md | Documents the dotnet/nbgv@master no-SHA-pin exception as an explicit repository rule. |
| .github/workflows/build-release-task.yml | Adds inline rationale for the existing dotnet/nbgv@master usage in the build/release workflow. |
ptr727
added a commit
that referenced
this pull request
Jun 29, 2026
Follow-up to #223: reword the inline comment and AGENTS note to the accurate cause (WORKFLOW.md D9.1 / 79-83) - nbgv's tag stream lags `master`, so Dependabot tag-tracking would only propose downgrades to stale tags. Converges the wording with PlexCleaner/VSCode/Utilities. Doc-only. Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This was referenced Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
nbgv already floats
@masterhere; this adds the inline rationale comment and theAGENTS.mdrule so the no-SHA-pin exception is explicit and converged fleet-wide (the tag stream lags master, so a pin draws spurious Dependabot downgrade PRs). Doc-only; no behavior change.