Conversation
nbgv already floats `@master` here; this adds the inline rationale comment and the `AGENTS.md` rule so the no-SHA-pin exception is explicit and converged fleet-wide (the tag stream lags master, so a pin draws spurious Dependabot downgrade PRs). Doc-only; no behavior change. Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Follow-up to #223: reword the inline comment and AGENTS note to the accurate cause (WORKFLOW.md D9.1 / 79-83) - nbgv's tag stream lags `master`, so Dependabot tag-tracking would only propose downgrades to stale tags. Converges the wording with PlexCleaner/VSCode/Utilities. Doc-only. Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Documents the existing dotnet/nbgv@master no-SHA-pin exception so the rationale is explicit and consistent across repo guidance and the workflow itself.
Changes:
- Add an
AGENTS.mdrule clarifying thatdotnet/nbgvintentionally floats on@masterand must not be SHA-pinned. - Add an inline workflow comment in
build-release-task.ymlexplaining the Dependabot/tag-lag rationale and referencingWORKFLOW.md D9.1.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| AGENTS.md | Documents the dotnet/nbgv@master no-SHA-pin exception as a repo rule and ties it to the workflow contract rationale. |
| .github/workflows/build-release-task.yml | Adds inline rationale comment near the existing dotnet/nbgv@master usage to make the exception self-explanatory. |
This was referenced Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Promotes the nbgv @master documentation (already floats @master here): the inline rationale comment + AGENTS.md note (accurate tag-lag wording) from #223 and the wording sharpen from #224. Doc-only convergence. No-bypass merge-commit promotion.