Promote develop to main#379
Merged
Merged
Conversation
… actions-deps group (#373) Bumps the actions-deps group with 1 update: [DavidAnson/markdownlint-cli2-action](https://github.com/davidanson/markdownlint-cli2-action). Updates `DavidAnson/markdownlint-cli2-action` from 23.2.0 to 24.0.0 <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/DavidAnson/markdownlint-cli2-action/commit/8de2aa07cae85fd17c0b35642db70cf5495f1d25"><code>8de2aa0</code></a> Update to version 24.0.0.</li> <li><a href="https://github.com/DavidAnson/markdownlint-cli2-action/commit/982cff12d7c65821c0dee94705c0881b1726c6ef"><code>982cff1</code></a> Freshen generated package-lock.json file.</li> <li><a href="https://github.com/DavidAnson/markdownlint-cli2-action/commit/2e007a07bb4809742406c9226c4e4937f2275103"><code>2e007a0</code></a> Freshen generated index.js file.</li> <li><a href="https://github.com/DavidAnson/markdownlint-cli2-action/commit/b25b0411eac314287d0eb6d33c9da6c99c82b471"><code>b25b041</code></a> Freshen generated index.js file.</li> <li><a href="https://github.com/DavidAnson/markdownlint-cli2-action/commit/d9ad5707f6c638bc9d5e9c46c98c75a7d07f2a81"><code>d9ad570</code></a> Bump markdownlint-cli2 from 0.22.1 to 0.23.0</li> <li><a href="https://github.com/DavidAnson/markdownlint-cli2-action/commit/2d0ebec8eaf1d290f24cfdeb0eaa5b03add6bf1e"><code>2d0ebec</code></a> Address new lint error from previous commit, freshen generated index.js file.</li> <li><a href="https://github.com/DavidAnson/markdownlint-cli2-action/commit/fcff1161eefc4f4abc780fe732ba51dd6c4da0d2"><code>fcff116</code></a> Bump eslint-plugin-unicorn from 66.0.0 to 68.0.0</li> <li><a href="https://github.com/DavidAnson/markdownlint-cli2-action/commit/7c806803da495d8f0d24bc1295b401b3ea38fe75"><code>7c80680</code></a> Bump actions/checkout from 6 to 7</li> <li><a href="https://github.com/DavidAnson/markdownlint-cli2-action/commit/501326c71f5d7fd8168403ebbb27500d4d99599a"><code>501326c</code></a> Freshen generated index.js file.</li> <li><a href="https://github.com/DavidAnson/markdownlint-cli2-action/commit/2bfaeca11595e3e14ffd0287630c73a8154d8c2d"><code>2bfaeca</code></a> Address new lint error from previous commit, freshen generated index.js file.</li> <li>Additional commits viewable in <a href="https://github.com/davidanson/markdownlint-cli2-action/compare/ded1f9488f68a970bc66ea5619e13e9b52e601cd...8de2aa07cae85fd17c0b35642db70cf5495f1d25">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore <dependency name> major version` will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself) - `@dependabot ignore <dependency name> minor version` will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself) - `@dependabot ignore <dependency name>` will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself) - `@dependabot unignore <dependency name>` will remove all of the ignore conditions of the specified dependency - `@dependabot unignore <dependency name> <ignore condition>` will remove the ignore condition of the specified dependency and ignore conditions </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Dependabot and GitHub Actions rewrite workflow YAML with LF, so this
declares LF for `.github/workflows/*.{yml,yaml}` in `.editorconfig` to
keep it consistent instead of mixed on every bump. Non-workflow YAML
stays CRLF.
- `.editorconfig`: add the `[.github/workflows/*.{yml,yaml}] end_of_line
= lf` section.
- Convert the five workflow files to LF (EOL-only; content-neutral).
- Add `.editorconfig-checker.json` (EOL-only checker config).
- Add a `Check line endings step` (editorconfig-checker) to the lint
job, right after actionlint.
- `AGENTS.md`: note the workflow-YAML LF exception.
git still leaves endings alone (`* -text`); `.editorconfig` plus the CI
editorconfig-checker step enforce the LF pin. Verified locally:
editorconfig-checker clean, and `git diff --ignore-cr-at-eol` on the
converted workflows is empty.
Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Collect Cobertura coverage during `dotnet test` and upload it to Codecov, best-effort (`fail_ci_if_error: false`, so a Codecov hiccup or an absent token never fails the gate). Mirrors the proven PlexCleaner pattern: - `validate-task.yml`: `dotnet test --collect:"XPlat Code Coverage" --results-directory ./coverage`, then a `codecov/codecov-action` upload step. - `test-pull-request.yml` and `publish-release.yml`: pass `secrets: inherit` on the `validate-task` call so `CODECOV_TOKEN` threads through to the unit-test job. - Reference `coverlet.collector` in `UtilitiesTests` (and `Directory.Packages.props`). Maintainer action required: add a `CODECOV_TOKEN` secret to the repo Actions secrets for uploads to authenticate. Until then, uploads are simply skipped and CI stays green. Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
# Conflicts: # .github/workflows/validate-task.yml
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
Contributor
There was a problem hiding this comment.
Pull request overview
Promotion of develop into main, primarily carrying CI/workflow hygiene updates: adding .NET code coverage collection + optional Codecov reporting, and codifying LF-only line endings for GitHub workflow YAML to avoid recurring merge/EOL conflicts in .github/workflows/.
Changes:
- Add Coverlet collector to the test project and central package versioning.
- Update reusable CI workflows to collect coverage, optionally upload to Codecov, and add an editorconfig-checker step to enforce line endings.
- Document the workflow-YAML LF exception and configure
.editorconfigaccordingly.
Reviewed changes
Copilot reviewed 8 out of 10 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| UtilitiesTests/UtilitiesTests.csproj | Adds coverlet.collector reference to enable dotnet test --collect coverage output. |
| Directory.Packages.props | Centralizes the coverlet.collector version. |
| AGENTS.md | Documents the workflow-YAML LF exception and how it’s enforced. |
| .github/workflows/validate-task.yml | Collects coverage during unit tests, uploads to Codecov (non-gating), and enforces EOL via editorconfig-checker. |
| .github/workflows/test-pull-request.yml | Threads secrets to the reusable validate task (for coverage upload). |
| .github/workflows/publish-release.yml | Threads secrets to the reusable validate task during publish validation. |
| .github/workflows/merge-bot-pull-request.yml | EOL-only promotion churn (no functional change apparent in diff). |
| .github/workflows/build-release-task.yml | EOL-only promotion churn (no functional change apparent in diff). |
| .editorconfig-checker.json | Configures editorconfig-checker (focused on enforcing EOL). |
| .editorconfig | Pins workflow YAML to LF while keeping other YAML CRLF. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Promotion of
developtomain. The directdevelop->mainmerge hit a spurious whole-file EOL conflict on workflow YAML (develop declared LF; main was CRLF); resolved by taking develop's versions — verified content-safe (identical modulo EOL, or develop is a superset; no main-only content dropped). For AudioCleaner, additionally verified the AssemblyAI feature is retained and 139 tests pass.🤖 Generated with Claude Code