Update dependency electron to v40.4.1#7827
Merged
Merged
Conversation
Owner
|
@copilot fix this please |
Contributor
renovate
Bot
force-pushed
the
renovate/electron-40.x
branch
from
February 16, 2026 14:12
efba876 to
78f0988
Compare
renovate
Bot
changed the title
renovate
Bot
force-pushed
the
renovate/electron-40.x
branch
from
February 16, 2026 15:35
78f0988 to
7131605
Compare
pubkey
pushed a commit
that referenced
this pull request
Jul 13, 2026
The test attached the .catch handler to migratePromise() only after an intervening `await waitUntil(...)`. When the migration rejected before the handler was attached (timing-dependent, hit on the CI runners), the test harness treated it as an unhandledRejection and exited with code 5. Catch the rejection synchronously at the call site and assert that the broadcastChannel is released (set back to undefined, which the fix only does after close() has run). This removes the capture-while-open race and keeps the test a valid guard for the leak. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UYki1roCApd2AaTxZ8ZJxj
pubkey
pushed a commit
that referenced
this pull request
Jul 13, 2026
async-test-util waitUntil() has no default timeout and polls forever. In the reproduction run (test executed without the source fix) the channel never becomes undefined, so the test hung until the browser CI runner was disconnected after ~26 minutes instead of failing cleanly. Pass an explicit 5s timeout so a regression fails fast with a clear "reached timeout" error. With the fix the channel is released in well under that bound. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UYki1roCApd2AaTxZ8ZJxj
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
40.3.0→40.4.1Release Notes
electron/electron (electron)
v40.4.1: electron v40.4.1Compare Source
Release Notes for v40.4.1
Other Changes
4835695. #49790v40.4.0: electron v40.4.0Compare Source
Release Notes for v40.4.0
Features
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.