`Snapshot` feature improvement

[Lore0599]

bender snapshot: preserve original source URL

Pitfall

When using bender clone, the local copy of a dependency is created under working_dir. In the Bender.lock, the dependency source is typically stored using the original HTTPS URL, for example:

source = "https://github.com/owner/repo.git"

However, during local development, it is common to manually change the Git remote of the cloned dependency from HTTPS to SSH:

git remote set-url origin git@github.com:owner/repo.git

After finishing the implementation, I usually go back to the parent project and run:

bender snapshot

This correctly updates the locked revision in Bender.lock to the latest commit of the local dependency. However, it also updates the dependency source URL from HTTPS to SSH, for example:

source = "git@github.com:owner/repo.git"

This can later break bender checkout.

Expected behavior

It would be useful if bender snapshot updated only the locked revision, while preserving the original source URL from the existing Bender.lock or Bender.yml.

Motivation

This would make the local development workflow smoother:

1. bender clone dependencies.
2. Change the local dependency remote to SSH to push development changes.
3. Implement and push changes.
4. Run bender snapshot in the parent project.
5. Commit the updated Bender.lock.

At the moment, step 4 also changes the source URL, which can accidentally make the lock file less portable and break checkout for other users or CI.

[fischeti]

I think one way around this issue is to not set and push to origin as a remote. I realized this by accident when working on the snitch cluster which does not allow pushing to the upstream directly, but instead relies on forks. So what you could do is:

git remote add origin2 git@github.com:owner/repo.git
git commit
git push origin2

I believe that should work, but probably needs to better explained in the docs. Or, we change bender to rename the origin remote, such that users can use origin.