Fix panic on lockfile choice' source not in any deps#300
Merged
Conversation
micprog
force-pushed
the
fix_choice_panic
branch
2 times, most recently
from
adbc8fd to
2a64044
Compare
micprog
force-pushed
the
fix_choice_panic
branch
2 times, most recently
from
efde0b1 to
839ab3b
Compare
fischeti
approved these changes
Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a lockfile uses a source url for a dependency no other dep uses (e.g., from an old requirement), and there is a dependency conflict on update, and the user selects the available lockfile version, there is a panic. This addresses that panic.