cdc_2phase: make sync stages configurable#336
Merged
Conversation
colluca
approved these changes
Jul 2, 2026
colluca
left a comment
colluca
left a comment
Contributor
There was a problem hiding this comment.
LGTM apart from following nitpick :)
| - cc_addr_decode_tb | ||
| - cc_cb_filter_tb | ||
| - cc_cdc_2phase_tb | ||
| - cc_cdc_2phase_clearable_tb |
Contributor
There was a problem hiding this comment.
I guess alphabetical order is in some sense wrong, unless you interpret _tb as a suffix that does not count towards the ordering. But I'd keep the ordering definition naive 😁
phsauter
changed the title
phsauter
force-pushed
the
phsauter/cdc-2phase
branch
from
d4a1978 to
d671979
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes SyncStages configurable for cc_cdc_2phase and forwards it into the source and destination synchronizers. Adds timed async-boundary test coverage for the 2-phase CDC.