Skip to content

Update for argonaut-codecs#651

Merged
thomashoneyman merged 8 commits intopurescript:masterfrom
thomashoneyman:master
Jul 16, 2020
Merged

Update for argonaut-codecs#651
thomashoneyman merged 8 commits intopurescript:masterfrom
thomashoneyman:master

Conversation

@thomashoneyman
Copy link
Member

@thomashoneyman thomashoneyman commented Jul 1, 2020

This PR updates the package set to accommodate the change to argonaut-codecs to introduce typed errors.

Currently, these libraries are being removed from the package set. As noted in #642 each of these (except trout-client, which is waiting on an update to hyper) have had pull requests open for 11 days at the time this PR was opened.

This isn't urgent to merge because most folks are on the older package set. However, Bower users are going to be installing incompatible versions of the other ~15 libraries that have been updated, so it's still good to merge this at some point in the next week or two.

@danieljharvey
Copy link
Contributor

Have just released v1.0.0 of refined that uses the new Argonaut.

@thomashoneyman
Copy link
Member Author

Thanks! There are now only 4 libraries in the package set affected by the change.

@thomashoneyman
Copy link
Member Author

thomashoneyman commented Jul 3, 2020

We're down to 3 libraries affected. I suggest we merge this in a week (next Friday), but I understand if we need to wait a little longer to try and get all the libraries in.

@thomashoneyman
Copy link
Member Author

@f-f The only remaining libraries affected are polyform-validators (@paluh) and option (@joneshf). I think this should be merged this Friday, but I am open to pushing it back another week.

@f-f
Copy link
Member

f-f commented Jul 15, 2020

@thomashoneyman nothing has moved in a week, so I'd say we could go ahead with this?

@thomashoneyman
Copy link
Member Author

Yes, let’s do it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants