Add mapAccumL/R #11
Merged
Add mapAccumL/R #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
We can probably add a faster version of this in |
Member
|
👍 |
Closed
|
In Haskell, the StateL and StateR types are not exported, but here they are. Should they be exported or kept private? |
Contributor
Author
|
@techtangents Yes, good point. They should be hidden. |
Contributor
Author
|
@techtangents @garyb @joneshf How does this look? |
Member
|
👍 |
Contributor
Author
|
Odd that docgen sees the instances for |
Member
|
Name desugaring probably doesn't check whether the instances are for a private class. Not really a problem but I'll open an issue for it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@garyb @joneshf Please review?