Fix auto type deduction failures when var name is an existing type name - #1447
Closed
chuckatkins wants to merge 3 commits into
Closed
Fix auto type deduction failures when var name is an existing type name#1447chuckatkins wants to merge 3 commits into
chuckatkins wants to merge 3 commits into
Conversation
Contributor
Author
|
Note that once #1428 is merged I'll rebase this and it should be ready to go. |
Member
|
Have you reported this bug to PGI? We can work around it, of course, but it's definitely a compiler bug. |
Member
|
Hi @chuckatkins, I've merged the first commit (a899dd0). The second (Utilize CMake's language standards abstraction when possible) is superseded by a larger PR that is still in the queue. Regarding the third (work around PGI compiler bugs by making changes throughout pybind11) -- sorry, no :(. If this was one of the major 3 (GCC, Clang, MSVC), I would be more open to this sort of thing. Best, |
Collaborator
|
@chuckatkins can you confirm PGI 18.7+ fixed the compiler bug? |
This was referenced Apr 25, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the continuation of #1431 and fixes #1381.
While this does address the PGI type deduction issues, pybind11 still won't correctly build with PGI without #1428.