Skip to content

Attempt to enable coverage on pypy#2463

Closed
alex wants to merge 4 commits into
pyca:masterfrom
alex:enable-coverage-pypy
Closed

Attempt to enable coverage on pypy#2463
alex wants to merge 4 commits into
pyca:masterfrom
alex:enable-coverage-pypy

Conversation

@alex

@alex alex commented Nov 1, 2015

Copy link
Copy Markdown
Member

Fixes #785

@alex alex added the testing label Nov 1, 2015
@codecov-io

Copy link
Copy Markdown

Current coverage is 99.98%

Merging #2463 into master will not affect coverage as of abc5b1b

@@            master   #2463   diff @@
======================================
  Files          125     125       
  Stmts        13773   13773       
  Branches      1472    1472       
  Methods          0       0       
======================================
  Hit          13771   13771       
  Partial          2       2       
  Missed           0       0       

Review entire Coverage Diff as of abc5b1b

Powered by Codecov. Updated on successful CI builds.

@reaperhulk

Copy link
Copy Markdown
Member

Well this does work now (big improvement over timing out the build because it took >50 min!). Makes pypy on OS X take 16-24 minutes though.

@alex

alex commented Nov 1, 2015

Copy link
Copy Markdown
Member Author

Yeah, that's pretty cruddy, is there a fixed point we want to hold out for?
I think this is realistic. I think if we reordered the OS X builds to go
before Linux builds we'd also get a reduction in overall build time

On Sun, Nov 1, 2015 at 4:28 PM, Paul Kehrer notifications@github.com
wrote:

Well this does work now (big improvement over timing out the build because
it took >50 min!). Makes pypy on OS X take 16-24 minutes though.


Reply to this email directly or view it on GitHub
#2463 (comment).

"I disapprove of what you say, but I will defend to the death your right to
say it." -- Evelyn Beatrice Hall (summarizing Voltaire)
"The people's good is the highest law." -- Cicero
GPG Key fingerprint: 125F 5C67 DFE9 4084

@reaperhulk

Copy link
Copy Markdown
Member

I'd like to see it take less time than python 2.6 before we turn it on.

We've reordered in the past and we had issues with the mac builders stalling and then the linux builders wouldn't run (when we wanted quicker feedback). Maybe a solution is to move the mac builds up but have one 2.7, one 3.5 and a linux docs job run at the very top.

@alex

alex commented Nov 1, 2015

Copy link
Copy Markdown
Member Author

We already have jenkins for basic validation, is there a reason not to let
that be our quick feedback?

On Sun, Nov 1, 2015 at 5:16 PM, Paul Kehrer notifications@github.com
wrote:

I'd like to see it take less time than python 2.6 before we turn it on.

We've reordered in the past and we had issues with the mac builders
stalling and then the linux builders wouldn't run (when we wanted quicker
feedback). Maybe a solution is to move the mac builds up but have one 2.7,
one 3.5 and a linux docs job run at the very top.


Reply to this email directly or view it on GitHub
#2463 (comment).

"I disapprove of what you say, but I will defend to the death your right to
say it." -- Evelyn Beatrice Hall (summarizing Voltaire)
"The people's good is the highest law." -- Cicero
GPG Key fingerprint: 125F 5C67 DFE9 4084

@reaperhulk

Copy link
Copy Markdown
Member

Good point -- I added the pep8 and docs jobs to jenkins specifically to give rapid feedback on that front. So then reordering is not necessarily a bad idea. In high queue situations it won't speed things up much, but it should shorten the total wall clock time for individual builds.

@alex

alex commented Nov 6, 2015

Copy link
Copy Markdown
Member Author

jenkins retest this please

@reaperhulk

Copy link
Copy Markdown
Member

Could we have it skip coverage on OS X pypy? That would avoid most of the performance penalty (23 minutes on OS X pypy due to the two backends) and I'd be happy to merge then (especially as we've now got two PRs that need pypy coverage)

@reaperhulk reaperhulk mentioned this pull request Jan 4, 2016
@reaperhulk

Copy link
Copy Markdown
Member

This was superseded by #2638

@reaperhulk reaperhulk closed this Jan 24, 2016
@alex alex deleted the enable-coverage-pypy branch January 24, 2016 04:01
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Aug 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Development

Successfully merging this pull request may close these issues.

Re-enable coverage on pypy.

3 participants