[WIP] cffi init_once (1.4+) support in the openssl backend#2537
[WIP] cffi init_once (1.4+) support in the openssl backend#2537reaperhulk wants to merge 2 commits into
Conversation
There was a problem hiding this comment.
Simplifies to cffi.__version_info__ >= (1, 4, 0)
There was a problem hiding this comment.
Can we namespace these tags a bit more.
|
Can we do this without moving any of the code around? Ideally just altering the callsites of these functions? |
Current coverage is
|
|
Ooof, coverage is a mess here because PyPy is the one platform we don't have coverage on :-( |
|
The coverage issue here is potentially resolved by merging #2463, although it will significantly increase our CI time. I don't really want to put this in the twelfth release though so we can wait on this one. |
|
I'm unwilling to land a change like this at the moment. Mostly because until we have static callbacks sorted out I'm gunshy about making another major change. Kicking this out of the thirteenth release. |
cffi added
init_oncesupport in version 1.4. This can alleviate a race for us around the registration of the osrandom engine, but since we don't want to bump our PyPy minimum version beyond 2.6 we need to support both code paths. I am far from confident that the current PR represents the right approach, but it should serve as a starting point to figure out what we want to do.