Corrected test parsing of certificates - #5978
Merged
Merged
Conversation
RFC 5280 says these fields are both `IMPLICIT` tagging, and `IMPLICIT` tagging is only `CONSTRUCTED` if the inner type is, and the inner type is `BIT STRING` here, which is not `CONSTRUCTED`. In practice this is irrelevant since _no one_ ever uses these fields
davidben
approved these changes
Apr 16, 2021
davidben
left a comment
davidben
left a comment
Contributor
There was a problem hiding this comment.
Oops yeah I must have missed the implicit here.
reaperhulk
approved these changes
Apr 16, 2021
Member
|
standard codecov is full of it comment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RFC 5280 says these fields are both
IMPLICITtagging, andIMPLICITtagging is onlyCONSTRUCTEDif the inner type is, and the inner type isBIT STRINGhere, which is notCONSTRUCTED.In practice this is irrelevant since no one ever uses these fields